feat: queued metrics, along with bug fixes for round robin queueing #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abelanger5
commented
Apr 4, 2024
| r2."status" = 'QUEUED' AND | ||
| workflowVersion."id" = $2 | ||
| r2."tenantId" = @tenantId::uuid AND | ||
| (r2."status" = 'QUEUED' OR r2."status" = 'RUNNING') AND |
There was a problem hiding this comment.
We are filling all available slots with a QUEUED or RUNNING status. We are obviously not going to pop the running status, but we want to figure out how many slots we have and only return queued runs in those slots.
grutt
approved these changes
Apr 4, 2024
| countRunsParams.GroupKey = sqlchelpers.TextFromStr(*opts.GroupKey) | ||
| } | ||
|
|
||
| runsCount, err := r.queries.CountWorkflowRunsRoundRobin(context.Background(), r.pool, countRunsParams) |
There was a problem hiding this comment.
do we need to update this for future strategies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an endpoint for getting queued metrics for concurrency groups.
Also fixes an ordering issue in the round robin queueing strategy where the queue was returned with an incorrect ordering (see comments in PR review).
Also adds better visualization for queued runs in the events view.
Type of change