8000 feat(docs): automatic theme by steebchen · Pull Request #386 · hatchet-dev/hatchet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(docs): automatic theme #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2024
Merged

feat(docs): automatic theme #386

merged 4 commits into from
Apr 17, 2024

Conversation

steebchen
Copy link
Collaborator
@steebchen steebchen commented Apr 16, 2024 •
edited
Loading

Description

fix #345

Type of change

  • Documentation change (pure documentation change)

What's Changed

@vercel Vercel
Copy link
vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 0:19am

@steebchen steebchen mentioned this pull request Apr 16, 2024
Closed
@grutt
Copy link
Contributor
grutt commented Apr 16, 2024

Thanks @steebchen . I tried something similar but it looks like the light theme has limited coverage:

Screenshot 2024-04-16 at 7 19 19 AM

@steebchen
Copy link
Collaborator Author

@grutt fixed by removing the fixed bg color in the main tag; I tried to set it only to dark but then it doesn't work when the user manually switches the theme. So I removed it completely for now.

Alternatively, we can opt in for the slightly different background color for the dark mode, but would then need to disable manual theme switching.

I think the best thing to do is what's in this PR: leave the default colors as is set by the default nextjs theme and detect the user's preferred theme. And optionally the user can switch it by using the integrated dark/light switcher in the bottom left.

@steebchen steebchen linked an issue Apr 16, 2024 that may be closed by this pull request
light theme #345
Closed
@grutt
Copy link
Contributor
grutt commented Apr 16, 2024 •
edited
Loading

Almost there! Almost there, code blocks are now unreadable.

Screenshot 2024-04-16 at 1 28 46 PM

@steebchen
Copy link
Collaborator Author

dammit, will take another look tomorrow in all places 😅

@steebchen
Copy link
Collaborator Author

ok done @grutt

@steebchen steebchen merged commit fcf28b3 into main Apr 17, 2024
@steebchen steebchen deleted the feat/docs-theme branch April 17, 2024 13:11
@steebchen steebchen requested a review from abelanger5 April 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grutt grutt grutt approved these changes

@abelanger5 abelanger5 Awaiting requested review from abelanger5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

light theme
2 participants
@steebchen @grutt
0