8000 upgrade go to 1.19 and pin cosign-installer to v2 by cpanato · Pull Request #203 · helm/chart-releaser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

upgrade go to 1.19 and pin cosign-installer to v2 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2022
Merged

upgrade go to 1.19 and pin cosign-installer to v2 #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3121395
upgrade go to 1.19 and pin cosign-installer to v2
cpanato Aug 17, 2022
1c6d0d3
update golangci-lint to v1.48.0
cpanato Aug 17, 2022
a3b7a9d
remove io/ioutil deprecations
cpanato Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.46.2
version: v1.48.0
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/helm/chart-releaser

go 1.18
go 1.19

require (
github.com/Songmu/retry v0.1.0
Expand Down
3 changes: 1 addition & 2 deletions pkg/git/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package git

import (
"fmt"
"io/ioutil"
"os"
"os/exec"
"strings"
Expand All @@ -26,7 +25,7 @@ type Git struct{}

// AddWorktree creates a new Git worktree with a detached HEAD for the given committish and returns its path.
func (g *Git) AddWorktree(workingDir string, committish string) (string, error) {
dir, err := ioutil.TempDir("", "chart-releaser-")
dir, err := os.MkdirTemp("", "chart-releaser-")
if err != nil {
return "", err
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/packager/packager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ package packager

import (
"fmt"
"io/ioutil"
"io"
"os"
"path/filepath"

Expand Down Expand Up @@ -67,7 +67,7 @@ func (p *Packager) CreatePackages() error {
}

downloadManager := &downloader.Manager{
Out: ioutil.Discard,
Out: io.Discard,
ChartPath: path,
Keyring: helmClient.Keyring,
Getters: getters,
Expand Down
3 changes: 1 addition & 2 deletions pkg/packager/packager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
package packager

import (
"io/ioutil"
"os"
"path/filepath"
"testing"
Expand All @@ -27,7 +26,7 @@ import (
)

func TestPackager_CreatePackages(t *testing.T) {
packagePath, _ := ioutil.TempDir(".", "packages")
packagePath, _ := os.MkdirTemp(".", "packages")
invalidPacka 8000 gePath := filepath.Join(packagePath, "bad")
file, _ := os.Create(invalidPackagePath)
t.Cleanup(func() {
Expand Down
7 changes: 3 additions & 4 deletions pkg/releaser/releaser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package releaser
import (
"context"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"testing"
Expand All @@ -41,7 +40,7 @@ type FakeGit struct {
}

func (f *FakeGit) AddWorktree(workingDir string, committish string) (string, error) {
dir, err := ioutil.TempDir("", "chart-releaser-")
dir, err := os.MkdirTemp("", "chart-releaser-")
if err != nil {
return "", err
}
Expand Down Expand Up @@ -98,7 +97,7 @@ func (f *FakeGitHub) CreatePullRequest(owner string, repo string, message string
}

func TestReleaser_UpdateIndexFile(t *testing.T) {
indexDir, _ := ioutil.TempDir(".", "index")
indexDir, _ := os.MkdirTemp(".", "index")
defer os.RemoveAll(indexDir)

fakeGitHub := new(FakeGitHub)
Expand Down Expand Up @@ -180,7 +179,7 @@ func TestReleaser_UpdateIndexFile(t *testing.T) {
}

func TestReleaser_UpdateIndexFileGenerated(t *testing.T) {
indexDir, _ := ioutil.TempDir(".", "index")
indexDir, _ := os.MkdirTemp(".", "index")
defer os.RemoveAll(indexDir)

fakeGitHub := new(FakeGitHub)
Expand Down
0