8000 added chart changes detection by monotek · Pull Request #6 · helm/kind-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added chart changes detection #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

added chart changes detection #6

wants to merge 1 commit into from

Conversation

monotek
Copy link
Contributor
@monotek monotek commented Dec 10, 2019

Signed-off-by: André Bauer andre.bauer@kiwigrid.com

checks for chart changes before kind setup to save time in ci.

added chart changes detection
f1bd90b 
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
This was referenced Dec 11, 2019
Merged
Closed
@monotek
Copy link
Contributor Author
monotek commented Dec 11, 2019

/assign @unguiculus

@unguiculus
Copy link
Member

Thanks for the PR. However, we should not add any Helm-specifics to this action. You can achieve what you want by only triggering a job when the charts directory has changes.

@unguiculus unguiculus closed this Dec 13, 2019
@monotek
Copy link
Contributor Author
monotek commented Dec 13, 2019 •
edited
Loading

Thanks for the hint :)

Unfortunately with this the ci wont even run so the user wont get an error message or some ci output at all.
I fear the user would wait for the ci or think its broken.

Example: kiwigrid/helm-charts#254

@scottrigby
Copy link
Member

How is this for an option? helm/charts-repo-actions-demo#8

@monotek
Copy link
Contributor Author
monotek commented Dec 18, 2019

Thanks, maybe i'll give it a try.

In the meantime i've put the chart changes detection in a separate job too, which fails and cancels Lint & Install, if no chart changes are detected.

See: https://github.com/kiwigrid/helm-charts/blob/master/.github/workflows/ci.yaml#L7

@scottrigby
Copy link
Member

I saw that (some nice stuff in there btw!). The reason I added conditionals instead is so the job doesn't fail, even if there are no charts. Generally people will want to make add master branch protection, including requiring the lint-test status check, which this way allows.

@scottrigby scottrigby mentioned this pull request Dec 18, 2019
Merged
@scottrigby scottrigby mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monotek @unguiculus @scottrigby @helm-bot
0