8000 Upgrade kubectl by davidkarlsen · Pull Request #11 · helm/kind-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade kubectl #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2019
Merged

Upgrade kubectl #11

merged 3 commits into from
Dec 22, 2019

Conversation

davidkarlsen
Copy link
Member
@davidkarlsen davidkarlsen commented Dec 20, 2019 •
edited
Loading

Signed-off-by: David J. M. Karlsen david@davidkarlsen.com

This change is Reviewable

@davidkarlsen
upgrade kubectl
3f45462 
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
unguiculus
unguiculus requested changes Dec 21, 2019
View reviewed changes
unguiculus
unguiculus reviewed Dec 21, 2019
View reviewed changes
@davidkarlsen @unguiculus
Update kind.sh
7c7c9db 
Co-Authored-By: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
@davidkarlsen davidkarlsen force-pushed the feature/upgradeKubectl branch from fa64f22 to 7c7c9db Compare December 21, 2019 11:08
@davidkarlsen
better variable name
c160f74 
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
scottrigby
scottrigby approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member
@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to make kubectl version configurable, but in the spirit of fast releasing we may as well wait till we have a use case (it will be easy enough to add later). lgtm 👍

@davidkarlsen
Copy link
Member Author

Ideally the version would follow the k8s version (e.g. kind node-image tag).

@unguiculus unguiculus changed the title upgrade kubectl Upgrade kubectl Dec 22, 2019
@unguiculus unguiculus merged commit 98cb04e into helm:master Dec 22, 2019
@davidkarlsen davidkarlsen deleted the feature/upgradeKubectl branch December 22, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottrigby scottrigby 5AAA scottrigby approved these changes

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidkarlsen @scottrigby @unguiculus @helm-bot
0