8000 Convert remaining CircleCI config to GitHub Actions by scottrigby · Pull Request #11820 · helm/helm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Convert remaining CircleCI config to GitHub Actions #11820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Convert remaining CircleCI config to GitHub Actions #11820

wants to merge 1 commit into from

Conversation

scottrigby
Copy link
Member
@scottrigby scottrigby commented Feb 14, 2023 •
edited
Loading

What this PR does / why we need it:

Special notes for your reviewer:

  • @sabre1041 I know you planned to get to this but I got frustrated by our Circle job blocker so went ahead and sketched this up.
  • @mattfarina I believe these are the only things from Circle config that are still missing from the existing GH actions. I'm trying out @bacongobbler's AZ storage upload action 😄 Can't test in this PR, I will have to test on my fork with credentials to a separate testing AZ account. Any suggestions apart from that?

If applicable:

  • this PR has been tested for backward compatibility - ⚠️ NOT YET. STILL NEEDS TO BE TESTED

@scottrigby
Convert remaining CircleCI config to GitHub Actions
9f15736 
Signed-off-by: Scott Rigby <scott@r6by.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2023
@scottrigby
Copy link
Member Author
scottrigby commented Feb 16, 2023 •
edited
Loading

@sabre1041 Closing this in favor of #11676. I think there are some things in my PR that would improve yours, but your PR has good things like pinning by sha, and it was first. So let's work on it together from yours and get this in 😄

@scottrigby scottrigby closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina Awaiting requested review from mattfarina

@sabre1041 sabre1041 Awaiting requested review from sabre1041

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scottrigby
0