8000 refactor: use os instead of ioutil's ReadDir by kallydev · Pull Request #9929 · helm/helm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: use os instead of ioutil's ReadDir #9929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

refactor: use os instead of ioutil's ReadDir #9929

merged 1 commit into from
Jul 12, 2021

Conversation

kallydev
Copy link
Contributor
@kallydev kallydev commented Jul 8, 2021

Signed-off-by: Kally Fox kallydev@gmail.com

What this PR does / why we need it:
Resolved #9926.

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@kallydev
refactor: use os instead of ioutil's ReadDir
f9b1445 
Signed-off-by: Kally Fox <kallydev@gmail.com>
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
cndoit18
cndoit18 reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor
@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to migrate, can we migrate all the ioutil to os or io?

@kallydev
Copy link
Contributor Author
kallydev commented Jul 9, 2021

If we want to migrate, can we migrate all the ioutil to os or io?

Yes, I have migrated all ioutil.ReadDir to os.ReadDir. Since this PR specifies binding to Issue, if we need to migrate other ioutil code to os or io, I suggest to do it in another PR.

@cndoit18
Copy link
Contributor
cndoit18 commented Jul 9, 2021

If we want to migrate, can we migrate all the ioutil to os or io?

Yes, I have migrated all ioutil.ReadDir to os.ReadDir. Since this PR specifies binding to Issue, if we need to migrate other ioutil code to os or io, I suggest to do it in another PR.

That looks great too.

@mattfarina mattfarina added this to the 3.7.0 milestone Jul 9, 2021
bacongobbler
bacongobbler approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member
@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

yxxhero
yxxhero approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member
@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hickeyma
hickeyma approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor
@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update @kallydev

@hickeyma hickeyma merged commit 433b90c into helm:main Jul 12, 2021
@kallydev kallydev mentioned this pull request Sep 28, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacongobbler bacongobbler bacongobbler approved these changes

@yxxhero yxxhero yxxhero approved these changes

@hickeyma hickeyma hickeyma approved these changes

@cndoit18 cndoit18 cndoit18 approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

refactor all use of ioutil.ReadDir
7 participants
@kallydev @cndoit18 @bacongobbler @yxxhero @hickeyma @mattfarina @helm-bot
0