Update Cobra to version 1.2.1 #9933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Testing that a bad completion directive was being replaced by the default one was actually testing Cobra's behaviour. This is unnecessary especially since that behaviour changed in the 1.2.0 release. Helm tests should focus on testing Helm's behaviour. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
mattfarina
reviewed
Jul 12, 2021
Comment on lines
-280
to
-284
| }, { | ||
| name: "completion for plugin bad directive", | ||
| cmd: "__complete echo ''", | ||
| golden: "output/plugin_echo_bad_directive.txt", | ||
| rels: []*release.Release{}, |
There was a problem hiding this comment.
Out of curiosity, why was this test dropped?
There was a problem hiding this comment.
(From the description of the PR 😄 ):
A completion test was removed in this PR as it was failing with the new version of Cobra.
The test was actually testing Cobra's behaviour (which changed in the new release), which is not something Helm tests should focus on, so I simply removed it.
I don't expect Cobra's change of behaviour to have much of an impact on Helm, and I was being over-zealous when I wrote the test.
hickeyma
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update to Cobra 1.2.1.
I don't know why Dependabot was not triggered for this.
The changes part of Cobra 1.2.1 are safe and are mostly focused on bug fixes for the completion support.
A bash completion V2 is also available. I will eventually post a PR proposing to use this new version.
Special notes for your reviewer:
A completion test was removed in this PR as it was failing with the new version of Cobra.
The test was actually testing Cobra's behaviour (which changed in the new release), which is not something Helm tests should focus on, so I simply removed it.
I don't expect Cobra's change of behaviour to have much of an impact on Helm, and I was being over-zealous when I wrote the test.
The completion tests of the acceptance-testing repo continue to pass.
Should I be checking the changes to go.sum in any way?