feat(helm): add --password-stdin to helm repo add
#9980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What* Without this commit, you can't pipe the password into `helm repo add`: ``` $ echo password | helm repo add repo-name https://repo-url --username username Password: Error: inappropriate ioctl for device ``` This commit introduces `--password-stdin`: ``` $ echo password | helm repo add repo-name https://repo-url --username username --password-stdin "repo-name" has been added to your repositories ``` **Why** There are two reasons I see for adding this: * I personally would expect that it's possible to pipe the password into `helm repo add` but that's currently not the case. If I understand it correctly, you currently either need to pass the password via a cli parameter (`--password`) or use a expect/send mechanism. * Subcommands like `helm registry login` already support `--password-stdin`. The cli interfaces should be consistent regarding which options they support. **Notes** I basically just copy-pasted code from `cmd/helm/registry_login.go`. Signed-off-by: André Schröder <andre.schroedr@gmail.com>
|
PRs must be linked to an existing issue. If none exists, may you please open one explaining the issue and expected outcome? |
cndoit18
reviewed
Jul 31, 2021
cndoit18
reviewed
Jul 31, 2021
Signed-off-by: André Schröder <andre.schroedr@gmail.com>
Signed-off-by: André Schröder <andre.schroedr@gmail.com>
b029df4 to
2131f4c
Compare
bacongobbler
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Without this commit, you can't pipe the password into
helm repo add:This commit introduces
--password-stdin:Fixes #10032
Why
There are two reasons I see for adding this:
I personally would expect that it's possible to pipe the password into
helm repo addbut that's currently not the case. If I understand itcorrectly, you currently either need to pass the password via a cli
parameter (
--password) or use a expect/send mechanism.Subcommands like
helm registry loginalready support--password-stdin. The cli interfaces should be consistent regardingwhich options they support.
Notes
I basically just copy-pasted code from
cmd/helm/registry_login.go.I don't know if this is the best approach to enable piping into the command. Maybe it would be sufficient to replace
term.ReadPassword(fd)with something else that also supports piping/ doesn't yieldinappropriate ioctl for device.Special notes for your reviewer:
If applicable: