Add deploy github actions workflows #9989
Conversation
3618152 to
e98f458
Compare
e98f458 to
a9cf372
Compare
Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
a9cf372 to
aa0ef89
Compare
|
Should the CircleCI config be removed as part of this? Or should this be done in a follow up after we see these actions working ? |
|
Good question. We probably want to disable CircleCI as soon as this is merged. Otherwise both Github Actions as well as CircleCI will be uploading competing uploads. We can fix these up in follow-up PRs if need be. Note that we do not have the secrets set in Github, so these actions will fail until we copy those over from CircleCI. Specifically,
|
Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
|
@bacongobbler This should be in good shape. Let me know if there is anything else you would like to see. |
There was a problem hiding this comment.
This looks great. Code LGTM.
Note that this will require some coordination before we merge, as we will need to migrate our existing credentials over from CircleCI to Github Actions. I'll see if I can find some time to do this a few weeks prior to Helm 3.8's scheduled release so we have a bit of a buffer before the next release is cut.
|
I scheduled myself to merge this PR today. Now that I realize it's Black Friday... Probably best to avoid merging code that could affect the release assets... Especially on the busiest sales day of the year. ;) I'll reschedule reviewing and merging this for Monday. Curious why CircleCI is failing to report its status here too. No matter - it will soon be gone :) |
|
This has already been completed in another PR so I'm closing this one. Thank you for the work and to try to help us along with this. |
Signed-off-by: Tyler Auerbeck tauerbec@redhat.com
refs #9921
What this PR does / why we need it:
This PR adds the remaining required github actions workflows in order to complete the transition from CircleCI. Specifically the following will now happen:
Special notes for your reviewer:
@bacongobbler This is about 99% complete. Just wanted to put this out as a draft for you to take a look at while I finish some final testing. One question I had is really around the release process. As I'm not familiar with the release process, I just copied what I saw in the
deploy.shscript. So things like do something when a tag is specified, etc. However, after doing some work in other helm repositories (chart-release, chart-testing), I noticed those repo's also had aworkflow-dispatchaction that allow them to trigger the release manually via GHA. Is this something that would be desired here? I've stubbed out a majority of it in case you would be interested. But otherwise, let me know and I can pull it out.This will require two secrets to be created inside of the repo in GitHub:
To take a look at the output of this, you can look at a successful run of the workflow here:
https://github.com/tylerauerbeck/helm/actions/runs/1099917788
If applicable: