8000 feat(comp): Move to Cobra's bash completion V2 by marckhouzam · Pull Request #9990 · helm/helm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(comp): Move to Cobra's bash completion V2 #9990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

feat(comp): Move to Cobra's bash completion V2 #9990

merged 1 commit into from
Aug 2, 2021

Conversation

marckhouzam
Copy link
Member
@marckhouzam marckhouzam commented Jul 31, 2021 •
edited
Loading

What this PR does / why we need it:

This change moves to use Cobra's new Bash Completion V2.
The V2 version has the following benefits:

  • provides completion descriptions as for the other shells
  • aligned with the completion logic for the other shells
  • uses a 300-line shell script (versus 4K lines for V1)

Here are some examples of descriptions enabled for bash:

$ bin/helm s<TAB><TAB>
search  (search for a keyword in charts)           status  (display the status of the named release)
show    (show information of a chart)

Special notes for your reviewer:

Backwards-compatibility has been tested with the acceptance-testing repo using PR helm/acceptance-testing#93

If applicable:

  • this PR has been tested for backwards compatibility

@marckhouzam
feat(comp): Move to Cobra's bash completion V2
bceaba9 
Cobra's bash completion V2 has the following benefits:
- aligned with the completion logic for the other shells
- provides completion descriptions as for the other shells
- uses a 300-line shell script (versus 4K lines for V1)

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2021
@marckhouzam marckhouzam mentioned this pull request Jul 31, 2021
Merged
@marckhouzam
Copy link
Member Author

Thanks @mattfarina !

@marckhouzam marckhouzam merged commit efe2638 into helm:main Aug 2, 2021
@marckhouzam marckhouzam deleted the feat/compBashDescriptions branch August 2, 2021 16:40
@marckhouzam marckhouzam mentioned this pull request Aug 3, 2021
Merged
1 task
@mattfarina mattfarina added this to the 3.7.0 milestone Aug 3, 2021
@marckhouzam marckhouzam mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina mattfarina approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marckhouzam @mattfarina @helm-bot
0