8000 fix: make sure to parse the yaml file not the path by SuzukiRyuichiro · Pull Request #51 · heroku/heroku-accounts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make sure to parse the yaml file not the path #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make sure to parse the yaml file not the path #51

wants to merge 2 commits into from

Conversation

SuzukiRyuichiro
Copy link
@SuzukiRyuichiro SuzukiRyuichiro commented Feb 6, 2025 •
edited
Loading

I am not aware of why but upon looking at some issues raised such as #50, I had an issue using the plugin. Looking at the code, it seemed that the YAML parser wasn't actually parsing YAML but the name of files? This fixed the issue

@SuzukiRyuichiro SuzukiRyuichiro mentioned this pull request Feb 6, 2025
Closed
k80bowman
k80bowman approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor
@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to fix the problem, thank you for submitting!

@ryandagg
Copy link
ryandagg commented Mar 4, 2025 •
edited
Loading

I'm no longer on the team responsible for this repo, but I verified the intended functionality of this change locally. The current release does not work for me and this change fixes it.

My steps:

  1. git clone https://github.com/SuzukiRyuichiro/heroku-accounts.git && cd heroku-accounts
  2. git checkout fix/cli-not-parsing-the-file
  3. used Node v18.16.1
  4. yarn
  5. heroku plugins:remove heroku-accounts
  6. heroku plugins:link
  7. removed/added accounts
  8. heroku labs
  9. heroku accounts:set otherAccount
  10. heroku labs

Expected results in all cases.

@k80bowman k80bowman mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k80bowman k80bowman k80bowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuzukiRyuichiro @ryandagg @k80bowman
0