Adding more restrictive eGPU detection #49
Conversation
Fixes hertg#48 Most GPUs register as "VGA compatible controller" in lspci. Adding this string to the regex search eliminates false positives for other devices that use the same PCI-E BusID, such as non-VGA devices connected via non-eGPU docks.
|
I've verified this fixed my issue, very similar to #48 (non eGPU dock) |
|
Hey, thanks for the PR! I would actually prefer to limit the results in the Limiting the results by filtering the device classes in lspci has proven to be more reliable than via grep. You can have a look at the |
|
Sounds good! I'll fix that PR up. Doing a quick glance at the display types supported, I presume we should ignore XGA (01) and Display Controller (80)? I don't see anything registering under those. |
using lspci filters vs regex match for VGA controller string, as the filters are more robust.
|
I did add that code-change to my local egpu-switcher, and it worked seamlessly on my TB3 Dock at work today.
I also haven't seen any of these before, so I don't really know what devices would register as XGA (01) or Display Controller (80). It's probably best to keep it like it is right now, instead of adding more device-classes we don't know enough about. There were no issues reported about undetected eGPUs since we changed to |
Fixes #48
Most GPUs register as "VGA compatible controller" in lspci. Adding this
string to the regex search eliminates false positives for other devices
that use the same PCI-E BusID, such as non-VGA devices connected via
non-eGPU docks.