8000 fix: handle getting data range for single data point by hkang1 · Pull Request #154 · hkang1/hermes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: handle getting data range for single data point #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

hkang1
Copy link
Owner
@hkang1 hkang1 commented Jun 22, 2023

When there is only a single data point, the range is invalid:
example:

data = [ 64 ]
range = [ 64, 64 ]

range with the same min and max values will render incorrectly.

@hkang1 hkang1 force-pushed the fix-single-data-point-case branch from 16adb44 to 169039a Compare June 22, 2023 05:30
@codecov
Copy link
codecov bot commented Jun 22, 2023

Codecov Report

Merging #154 (169039a) into main (17c45d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          17       17           
  Lines        1846     1855    +9     
  Branches      645      651    +6     
=======================================
+ Hits         1839     1848    +9     
  Misses          7        7           
Impacted Files Coverage Δ
src/utils/data.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hkang1 hkang1 enabled auto-merge June 22, 2023 05:32
@hkang1 hkang1 disabled auto-merge June 22, 2023 05:33
@hkang1 hkang1 merged commit 048f8e0 into main Jun 22, 2023
@hkang1 hkang1 deleted the fix-single-data-point-case branch June 22, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0