8000 EXUI-3057: service override settings by MunishSharmaHMCTS · Pull Request #884 · hmcts/rpx-xui-approve-org · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

EXUI-3057: service override settings #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

EXUI-3057: service override settings #884

wants to merge 11 commits into from

Conversation

MunishSharmaHMCTS
Copy link
Contributor
@MunishSharmaHMCTS MunishSharmaHMCTS commented May 9, 2025 •
edited
Loading

Jira link

https://tools.hmcts.net/jira/browse/EXUI-3057

Change description

setting up serviceOverride settings

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

anthonydummer
anthonydummer previously approved these changes May 14, 2025
View reviewed changes
Josh-HMCTS
Josh-HMCTS previously approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@Josh-HMCTS Josh-HMCTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just double check about the idamClientID being set in the config files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywilkinshmcts andywilkinshmcts andywilkinshmcts approved these changes

@Josh-HMCTS Josh-HMCTS Josh-HMCTS left review comments

@anthonydummer anthonydummer anthonydummer left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enable_keep_helm ns:xui prd:xui rel:xui-ao-webapp-pr-884
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MunishSharmaHMCTS @andywilkinshmcts @Josh-HMCTS @anthonydummer
0