8000 chore: improve config docs gen by leggetter · Pull Request #426 · hookdeck/outpost · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: improve config docs gen #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025
Merged

Conversation

leggetter
Copy link
Collaborator

Implements #415

@alexluong - I noticed that the Azure update highlighted the brittle nature of the existing codegen. So, I've taken your suggestions and added it in this PR.

@Copilot Copilot AI review requested due to automatic review settings June 9, 2025 20:46
Copy link
vercel bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outpost-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 9:38pm
outpost-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 9:38pm

Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the configuration documentation and code generation by standardizing the YAML structure and enhancing inline guidance.

  • Updates configuration tables to remove extra commentary and add concise "Required" markers.
  • Enhances YAML documentation for various configuration sections including alerts, message queues, and OpenTelemetry settings.
  • Adds a Makefile target to generate configuration docs.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/pages/references/configuration.mdx Standardizes YAML comments and configuration key documentation.
Makefile Adds a new target to generate configuration docs.

Comment on lines 309 to 314
exporter: ""

# Specifies the OTLP exporter to use for this telemetry type (e.g., 'otlp'). Typically used with environment variables like OTEL_EXPORTER_OTLP_TRACES_ENDPOINT.
# Required: C
exporter: ""

Copy link
Preview
Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate 'exporter' keys found in the 'otel.logs' section can lead to unintended configuration overrides; please consolidate them into a single key.

Suggested change
exporter: ""
# Specifies the OTLP exporter to use for this telemetry type (e.g., 'otlp'). Typically used with environment variables like OTEL_EXPORTER_OTLP_TRACES_ENDPOINT.
# Required: C
exporter: ""

Copilot uses AI. Check for mistakes.

Comment on lines 319 to 327
# Specifies the OTLP protocol ('grpc' or 'http') for this telemetry type. Typically used with environment variables like OTEL_EXPORTER_OTLP_TRACES_PROTOCOL.
# Required: C
protocol: ""

# Specifies the OTLP protocol ('grpc' or 'http') for this telemetry type. Typically used with environment variables like OTEL_EXPORTER_OTLP_TRACES_PROTOCOL.
# Required: C
protocol: ""


Copy link
Preview
Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple 'protocol' keys in the 'otel.logs' section may cause ambiguity in configuration; consider removing the redundant declarations.

Suggested change
# Specifies the OTLP protocol ('grpc' or 'http') for this telemetry type. Typically used with environment variables like OTEL_EXPORTER_OTLP_TRACES_PROTOCOL.
# Required: C
protocol: ""
# Specifies the OTLP protocol ('grpc' or 'http') for this telemetry type. Typically used with environment variables like OTEL_EXPORTER_OTLP_TRACES_PROTOCOL.
# Required: C
protocol: ""

Copilot uses AI. Check for mistakes.

@leggetter leggetter requested a review from alexluong June 9, 2025 21:29
@leggetter
Copy link
Collaborator Author

Merging as I want to create a guide and I need the config.

@leggetter leggetter merged commit 33d3fb4 into azure Jun 10, 2025
4 checks passed
@leggetter leggetter deleted the chore/improve-config-docs-gen branch June 10, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0