8000 Fix ChatInterface send with widget with no value_input by ahuang11 · Pull Request #6505 · holoviz/panel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix ChatInterface send with widget with no value_input #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2024
Merged

Fix ChatInterface send with widget with no value_input #6505

merged 1 commit into from
Mar 16, 2024

Conversation

ahuang11
Copy link
Contributor

Fixes this:

  File "/Users/ahuang/miniconda3/envs/panel-chat-examples/lib/python3.10/site-packages/panel/chat/interface.py", line 372, in _click_send
    value = active_widget.value or active_widget.value_input
AttributeError: 'RadioButtonGroup' object has no attribute 'value_input'

@ahuang11 ahuang11 requested a review from philippjfr March 15, 2024 23:17
@ahuang11 ahuang11 changed the title Fix value input chat Fix ChatInterface send with widget with no value_input Mar 15, 2024
@codecov Codecov
Copy link
codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (a23af62) to head (0ec3f24).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6505      +/-   ##
==========================================
- Coverage   82.92%   82.90%   -0.02%     
==========================================
  Files         312      312              
  Lines       45815    45823       +8     
==========================================
+ Hits        37990    37991       +1     
- Misses       7825     7832       +7
Flag Coverage Δ
ui-tests 39.64% <22.22%> (+0.01%) ⬆️
unitexamples-tests 71.13% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 added this to the v1.4.0 milestone Mar 16, 2024
@philippjfr philippjfr merged commit c89841a into main Mar 16, 2024
@philippjfr philippjfr deleted the fix_value_input_chat branch March 16, 2024 08:34
@philippjfr philippjfr mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ahuang11 @philippjfr
0