-
-
Notifications
You must be signed in to change notification settings - Fork 77
Added HTML repr for Parameterized #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
88130ee
Added HTML repr for Parameterized
jbednar 25d2203
Render objects and implement Parameterized.param repr
philippjfr 329fac9
Handle recursion
philippjfr af47f28
Improve mode and add doc tooltip
philippjfr 1ad9c68
Merge branch 'main' into htmlrepr
maximlt 73feda8
Merge branch 'main' into htmlrepr
maximlt a4afb47
document
maximlt 618b88e
replace bothmethod implementation so the method has the right type fo…
maximlt 0331e92
add test for bothmethod
maximlt 6d9b07a
wraps the recursive_repr decorator
maximlt a2ddcb8
make _name_if_set private
maximlt 069e4b9
re-add help image
maximlt 2d3d192
display the class directly in the docs
maximlt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it supposed to display classes with the rich output? If so that's not what I see:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would expect and hope for rich output for both classes and instances. Maybe a missing
@bothmethod
elsewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation of
bothmethod
was turning the method into afunctools.partial
object whose type is notMethodType
(notFunctionType
either). IPython checks the type of the repr function (e.g._repr_html_
) on the object to be displayed:https://github.com/ipython/ipython/blob/9da6376aa74dad72f5a84cdd0bf5ad0f1d809308/IPython/utils/dir2.py#L78-L79
This was failing with the current implementation, which I have replaced in 618b88e to satisfy IPython's inspection approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.