Can't change the port number for netgear integration #57196

yiweiyu32 · 2021-10-06T19:28:12Z

The problem

With 2021.10, netgear migration has moved from yaml to UI. However the port number defaults to 5000 and there's no option to set it to a different port to account for products like orbi routers.

What is version of Home Assistant Core has the issue?

core-2021.10.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Netgear

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

SNoof85 · 2021-10-06T20:19:03Z

I have no netgear at home but can try to setup the integration with UI config flow and I get this :

where i can definitely change the port.

yiweiyu32 · 2021-10-06T21:19:18Z

I'm seeing a different pop up screen.

probot-home-assistant · 2021-10-06T21:33:01Z

Hey there @hacf-fr, @Quentame, @starkillerOG, mind taking a look at this issue as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

netgear documentation
netgear source
_{^{(message by IssueLinks)}}

starkillerOG · 2021-10-07T07:24:40Z

@yiweiyu32 if the device is automatically discovered you can't change the port, but it schould be the correct port actually.
However if you need to change the port, simply ignore the automatically discovered device and configure it manually.
(Hit the + icon on the bottom right and search for Netgear) than it schould give you the option to specify the port.

yiweiyu32 · 2021-10-07T12:54:58Z

@starkillerOG Agree on the 2nd part. Was able to configure it manually. In my case the automatically discovered default port (5000) is not correct since I'm using a Orbi router (port 80) and that's what this issue is about.

starkillerOG · 2021-10-07T18:20:49Z

I included a debug log for the SSDP discovery information in this PR: #57226
Could you test that and put the log level of the netgear integration to debug and then report the discovery infromation here?

yiweiyu32 · 2021-10-08T12:44:08Z

@starkillerOG
async_step_ssdp: discovery_info: {'CACHE-CONTROL': 'max-age=60', 'DATE': 'xxx', 'ssdp_st': 'urn:schemas-upnp-org:device:InternetGatewayDevice:1', 'ssdp_usn': 'uuid:xxxx::urn:schemas-upnp-org:device:InternetGatewayDevice:1', 'ssdp_ext': '', 'ssdp_server': 'OpenWRT/OpenWrt UPnP/1.0 MiniUPnPd/1.9', 'OPT': '"http://schemas.upnp.org/upnp/1/0/"; ns=01', '01-NLS': 'xxxx', 'BOOTID.UPNP.ORG': 'xxxx', 'CONFIGID.UPNP.ORG': 'xxxx', '_location_original': 'http://192.168.1.1:5000/rootDesc.xml', 'ssdp_location': 'http://192.168.1.1:5000/rootDesc.xml',
...
'manufacturer': 'NETGEAR, Inc.', 'manufacturerURL': 'http://www.NETGEAR.com', 'modelDescription': 'NETGEAR CBR40 802.11ac Wireless Router',
...

starkillerOG · 2021-10-08T16:40:45Z

@yiweiyu32 so this basically only shows 5000 as the port, but no where does it refrence the correct port: 80.
Can you look how the http://192.168.1.1:5000/rootDesc.xml file looks like?

yiweiyu32 · 2021-10-08T16:44:38Z

<root> <specVersion> <major>1</major> <minor>0</minor> </specVersion> <device> <deviceType> urn:schemas-upnp-org:device:InternetGatewayDevice:1 </deviceType> <friendlyName>CBR40 (Gateway)</friendlyName> <manufacturer>NETGEAR, Inc.</manufacturer> <manufacturerURL>http://www.NETGEAR.com</manufacturerURL> <modelDescription>NETGEAR CBR40 802.11ac Wireless Router</modelDescription> <modelName>CBR40</modelName> <modelNumber>1</modelNumber> <modelURL>http://www.netgear.com</modelURL> <serialNumber>xxxx</serialNumber> <UDN>uuid:xxxx</UDN> <serviceList> <service> <serviceType>urn:schemas-upnp-org:service:Layer3Forwarding:1</serviceType> <serviceId>urn:upnp-org:serviceId:Layer3Forwarding1</serviceId> <controlURL>/ctl/L3F</controlURL> <eventSubURL>/evt/L3F</eventSubURL> <SCPDURL>/L3F.xml</SCPDURL> </service> </serviceList> <deviceList> <device> <deviceType>urn:schemas-upnp-org:device:WANDevice:1</deviceType> <friendlyName>CBR40 (Gateway)</friendlyName> <manufacturer>NETGEAR, Inc.</manufacturer> <manufacturerURL>http://www.NETGEAR.com</manufacturerURL> <modelDescription>NETGEAR CBR40 802.11ac Wireless Router</modelDescription> <modelName>CBR40</modelName> <modelNumber>1</modelNumber> <modelURL>http://www.netgear.com</modelURL> <serialNumber>xxxx</serialNumber> <UDN>xxxx</UDN> <UPC>xxxx</UPC> <serviceList> <service> <serviceType> urn:schemas-upnp-org:service:WANCommonInterfaceConfig:1 </serviceType> <serviceId>urn:upnp-org:serviceId:WANCommonIFC1</serviceId> <controlURL>/ctl/CmnIfCfg</controlURL> <eventSubURL>/evt/CmnIfCfg</eventSubURL> <SCPDURL>/WANCfg.xml</SCPDURL> </service> </serviceList> <deviceList> <device> <deviceType>urn:schemas-upnp-org:device:WANConnectionDevice:1</deviceType> <friendlyName>CBR40 (Gateway)</friendlyName> <manufacturer>NETGEAR, Inc.</manufacturer> <manufacturerURL>http://www.NETGEAR.com</manufacturerURL> <modelDescription>NETGEAR CBR40 802.11ac Wireless Router</modelDescription> <modelName>CBR40</modelName> <modelNumber>1</modelNumber> <modelURL>http://www.netgear.com</modelURL> <serialNumber>xxxx</serialNumber> <UDN>uuid:xxxx</UDN> <UPC>xxxx</UPC> <serviceList> <service> <serviceType>urn:schemas-upnp-org:service:WANIPConnection:1</serviceType> <serviceId>urn:upnp-org:serviceId:WANIPConn1</serviceId> <controlURL>/ctl/IPConn</controlURL> <eventSubURL>/evt/IPConn</eventSubURL> <SCPDURL>/WANIPCn.xml</SCPDURL> </service> </serviceList> </device> </deviceList> </device> </deviceList> <presentationURL>http://192.168.1.1/</presentationURL> </device> </root>
@starkillerOG

starkillerOG · 2021-10-08T16:56:47Z

well I don't see the correct port 80 in here as well.
You can't find anywhere port 80 in some of the commented out parts right?
Then I guess that we will need to match model for the Orbi series and set the port from a lookup dict.

yiweiyu32 · 2021-10-08T17:00:42Z

Yea, I can't find any mentioning of port 80. Just so you're aware this (Orbi's having a different default port) is pointed out in this page https://www.home-assistant.io/integrations/netgear/ but I'm not sure if that list is exhaustive.

yiweiyu32 · 2021-10-08T17:04:02Z

Another way to look at this is that since port 80 is the default http port, if there's no mention of port 5000 in some specific places (in some http urls) maybe we should set the default port to 80

starkillerOG · 2021-10-08T17:04:37Z

Yes I am aware, I re-wrote that whole page :)
I have a prety exaustive list already of the orbi models since I needed that to determine which API method to use.

starkillerOG · 2021-10-08T17:06:42Z

All other models exept the orbi range use port 5000.
Apperently also the Orbi models list port 5000 in the SSDP information, so that does not help much.

I think using the model from SSDP information and matching to known orbi models here

core/homeassistant/components/netgear/const.py

Lines 14 to 31 in 7e34860

    
           MODELS_V2 = [ 
        
               "Orbi", 
        
               "RBK", 
        
               "RBR", 
        
               "RBS", 
        
               "RBW", 
        
               "LBK", 
        
               "LBR", 
        
               "CBK", 
        
               "CBR", 
        
               "SRC", 
        
               "SRK", 
        
               "SRR", 
        
               "SRS", 
        
               "SXK", 
        
               "SXR", 
        
               "SXS", 
        
           ]

is the best option.

yiweiyu32 · 2021-10-08T22:03:21Z

Awesome. Will help test it out once the cha 8000 nge's been released. Thanks!

starkillerOG · 2021-10-11T08:02:36Z

@yiweiyu32 I think this PR will fix the auto-discovery: #57432
Would be nice if you could test it and report back

starkillerOG · 2021-10-11T18:43:59Z

@yiweiyu32 the fix will be in HomeAssistant 2021.10.4, could you test that once it comes out in a few days and see if auto-discovery now works withouth specifying the port?

yiweiyu32 · 2021-10-12T12:40:11Z

@starkillerOG upgraded 2021.10.4, restarted home assistant and it's still showing that the auto discovered port is 5000.

starkillerOG · 2021-10-14T20:34:18Z

@yiweiyu32 are you sure you are on 2021.10.4?
It did work for two other people using orbi routers that now use the correct port 80.
Did you remove your existing Netgear integration before restarting?

In the discovery debug log you posted here #57196 (comment), not everything was included. Specifically I match the "modelNumber" to the known Orbi models.

Could you provide the "modelNumber" as listed in the discovery debug log?

yiweiyu32 · 2021-10-14T21:37:28Z

@starkillerOG Checked the hass version, removed the existing integration, restarted hass and I'm still seeing the wrong port (5000).
'modelNumber': '1'

starkillerOG · 2021-10-17T13:33:03Z

Alright, so normally the modelNumber reports the model of the device, apperently for you this is not the case, that is why the fix did not work.
I will also check for modelName which does report the correct model in your router.

starkillerOG · 2021-10-17T13:40:05Z

This PR will also check the modelName tag: #57904

yiweiyu32 · 2021-10-18T02:34:06Z

Thanks! Will retest it. What would the fix version be? @starkillerOG

starkillerOG · 2021-10-18T10:03:25Z

@yiweiyu32 it will be in 2021.10.7
That will probably be released in a few days.

yiweiyu32 · 2021-11-18T13:45:42Z

Tested this in core-2021.11.4. The integration can now discover the correct port for my orbit router.

chemelli74 added the integration: netgear label Oct 6, 2021

starkillerOG mentioned this issue Oct 7, 2021

Add Netgear ssid and conn_ap_mac sensors #57226

Merged

22 tasks

starkillerOG mentioned this issue Oct 7, 2021

Netgear fix port and device model beeing overwritten #57277

Merged

22 tasks

starkillerOG mentioned this issue Oct 8, 2021

Connection issue with netgear integration #57244

Closed

starkillerOG mentioned this issue Oct 11, 2021

Fix Netgear orbi port in ssdp discovery #57432

Merged

21 tasks

starkillerOG mentioned this issue Oct 17, 2021

Fix netgear NoneType and discovery #57904

Merged

22 tasks

yiweiyu32 closed this as completed Nov 18, 2021

github-actions bot locked and limited conversation to collaborators Dec 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Can't change the port number for netgear integration #57196

Can't change the port number for netgear integration #57196

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Can't change the port number for netgear integration #57196

Can't change the port number for netgear integration #57196

Comments

The problem

What is version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!