8000 Add Netgear ssid and conn_ap_mac sensors by starkillerOG · Pull Request #57226 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Netgear ssid and conn_ap_mac sensors #57226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 11, 2021
Merged

Add Netgear ssid and conn_ap_mac sensors #57226

merged 17 commits into from
Oct 11, 2021

Conversation

starkillerOG
Copy link
Contributor
@starkillerOG starkillerOG commented Oct 7, 2021 •
edited
Loading

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@starkillerOG starkillerOG requested a review from Quentame as a code owner October 7, 2021 06:55
@probot-home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@starkillerOG starkillerOG mentioned this pull request Oct 7, 2021
Closed
MartinHjelmare
MartinHjelmare requested changes Oct 7, 2021
View reviewed changes
starkillerOG and others added 4 commits October 7, 2021 09:03
@starkillerOG @MartinHjelmare
Update homeassistant/components/netgear/sensor.py
fdbf609 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@starkillerOG @MartinHjelmare
Update homeassistant/components/netgear/sensor.py
fee3999 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@starkillerOG
remove defaults
0c84dec
MartinHjelmare
MartinHjelmare reviewed Oct 7, 2021
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all these sensors are disabled by default, I think it's ok.

@MartinHjelmare
Copy link
Member

Please run black.

@starkillerOG starkillerOG changed the title Netgear add ssid, conn_ap_mac and allow_or_block sensors Netgear add ssid and conn_ap_mac sensors Oct 7, 2021
@MartinHjelmare MartinHjelmare changed the title Netgear add ssid and conn_ap_mac sensors Add Netgear ssid and conn_ap_mac sensors Oct 7, 2021
@starkillerOG
add debug to ssdp discovery
c737219
@starkillerOG
do not overwrite model if it is None
fed81eb 
The model of the device would be overwritten to None if it was already known by another integration with the same mac connection.
The router does not always provide model information
@starkillerOG
fix isort
c8a548b
@starkillerOG
Do not update port of already setup router
2a963f1
This was referenced Oct 7, 2021
Closed
Closed
MartinHjelmare
MartinHjelmare reviewed Oct 7, 2021
View reviewed changes
@starkillerOG
Copy link
Contributor Author

I am also still testing

@starkillerOG
Copy link
Contributor Author

I removed the fixes and moved them to this PR: #57277

@starkillerOG
Copy link
Contributor Author

One thing to note is that these new ssid and conn_ap_mac sensors will only work when using the V2 update method, so at the moment only with orbi routers.
On other routers these sensors will always be None (since they always use V1 update method because it is less load on the router).

@MartinHjelmare
Copy link
Member

Can we check model before we create the sensors so we don't create sensors that never will update?

@starkillerOG
Copy link
Contributor Author

We probably can, will try to work on that tommorow

MartinHjelmare
MartinHjelmare requested changes Oct 8, 2021
View reviewed changes
@MartinHjelmare MartinHjelmare marked this pull request as draft October 8, 2021 06:52
@MartinHjelmare
Copy link
Member

We'll hold this until we've merged the fix PR.

@starkillerOG
Copy link
Contributor Author

@MartinHjelmare since the fix PR is now merged, can this also be merged?

@MartinHjelmare MartinHjelmare marked this pull request as ready for review October 8, 2021 17:50
MartinHjelmare
MartinHjelmare reviewed Oct 8, 2021
View reviewed changes
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare last revieuw comment processed, and tests have passed.
Ready to be merged.

@MartinHjelmare MartinHjelmare merged commit 1fbc94f into home-assistant:dev Oct 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@Quentame Quentame Awaiting requested review from Quentame Quentame is a code owner

Assignees
No one assigned
Labels
by-code-owner cla-signed Hacktoberfest integration: netgear new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@starkillerOG @MartinHjelmare @homeassistant
0