8000 Vizio coordinator update test is flaky · Issue #50795 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Vizio coordinator update test is flaky #50795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KapJI opened this issue May 17, 2021 · 1 comment · Fixed by #50948
Closed

Vizio coordinator update test is flaky #50795

KapJI opened this issue May 17, 2021 · 1 comment · Fixed by #50948
Assignees
@raman325
Labels
integration: vizio

Comments

@KapJI
Copy link
Member
KapJI commented May 17, 2021 •
edited
Loading

The problem

I've seen this test failing multiple times on unrelated PRs and it requires restarting the whole CI to pass all jobs.

Test name: tests/components/vizio/test_init.py::test_coordinator_update_failure

Example which failed on dev branch: https://github.com/home-assistant/core/runs/2594855564

I think this test should be fixed or removed.

cc @raman325

What is version of Home Assistant Core has the issue?

dev

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

Vizio

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

        async_fire_time_changed(hass, now + timedelta(days=10))
        await hass.async_block_till_done()
>       assert "Unable to retrieve the apps list from the external server" in caplog.text
E       AssertionError: assert 'Unable to retrieve the apps list from the external server' in 'INFO     homeassistant.loader:loader.py:344 Loaded vizio from homeassistant.components.vizio\nINFO     homeassistant....nds\nDEBUG    homeassistant.components.vizio:update_coordinator.py:253 Finished fetching vizio data in 0.000 seconds\n'
E        +  where 'INFO     homeassistant.loader:loader.py:344 Loaded vizio from homeassistant.components.vizio\nINFO     homeassistant....nds\nDEBUG    homeassistant.components.vizio:update_coordinator.py:253 Finished fetching vizio data in 0.000 seconds\n' = <_pytest.logging.LogCaptureFixture object at 0x7fb8458e2910>.text

Additional information

No response
@bdraco
Copy link
Member
bdraco commented May 17, 2021

Failed on https://github.com/home-assistant/core/pull/50784/checks?check_run_id=2605243861

@raman325 raman325 mentioned this issue May 22, 2021
Merged
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@raman325 raman325

Labels
integration: vizio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky vizio test and add comments to explain logic raman325/home-assistant
3 participants
@bdraco @KapJI @raman325
0