8000 Fix flaky vizio test and add comments to explain logic by raman325 · Pull Request #50948 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix flaky vizio test and add comments to explain logic #50948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2021
Merged

Fix flaky vizio test and add comments to explain logic #50948

merged 1 commit into from
May 22, 2021

Conversation

raman325
Copy link
Contributor
@raman325 raman325 commented May 22, 2021 •
edited
Loading

Proposed change

I've gotten multiple reports of a flaky test. My guess is due to a timing issue where I was fast forwarding time by a day 10 times because my data update coordinator has a day long time interval, and one of those fast forwards did not consistently trigger the data coordinator to update, which would cause the test to fail because I needed it to refresh ten times to get the expected condition. This new way of testing it should be more reliable because it guarantees enough refreshes that the log message should always get logged.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit 92d1871 into home-assistant:dev May 22, 2021
@KapJI
Copy link
Member
KapJI commented May 22, 2021

Thanks for fixing this!

@raman325 raman325 deleted the fix_test branch May 23, 2021 04:32
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality has-tests integration: vizio small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vizio coordinator update test is flaky
4 participants
@raman325 @MartinHjelmare @KapJI @homeassistant
0