10000 Neato platform is throwing errors in the log when robot is offline · Issue #6691 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Neato platform is throwing errors in the log when robot is offline #6691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emilp333 opened this issue Mar 19, 2017 · 0 comments · Fixed by #6731
Closed

Neato platform is throwing errors in the log when robot is offline #6691

emilp333 opened this issue Mar 19, 2017 · 0 comments · Fixed by #6731

Comments

@emilp333
Copy link
emilp333 commented Mar 19, 2017 •
edited
Loading

Make sure you are running the latest version of Home Assistant before reporting an issue.

Home Assistant release (hass --version):
0.40.1

Python release (python3 --version):
3.4.2

Component/platform:
Sensor/Neato

Description of problem:
Neato platform is throwing errors if the robot is offline.

Expected:
Status should change to offline and not flood the log with errors.

Log:

17-03-19 10:42:55 ERROR (MainThread) [homeassistant.components.sensor] Error while update entity from neato in sensor
Traceback (most recent call last):
File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 428, in _update_entity_states
yield from update_coro
File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/helpers/entity.py", line 207, in async_update_ha_state
yield from self.hass.loop.run_in_executor(None, self.update)
File "/usr/lib/python3.4/asyncio/futures.py", line 388, in iter
yield self # This tells Task to wait for completion.
File "/usr/lib/python3.4/asyncio/tasks.py", line 286, in _wakeup
value = future.result()
File "/usr/lib/python3.4/asyncio/futures.py", line 277, in result
raise self._exception
File "/usr/lib/python3.4/concurrent/futures/thread.py", line 54, in run
result = self.fn(*self.args, **self.kwargs)
File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/sensor/neato.py", line 55, in update
self._state = self.robot.state
File "/home/homeassistant/.homeassistant/deps/pybotvac/robot.py", line 94, in state
return self.get_robot_state().json()
File "/home/homeassistant/.homeassistant/deps/pybotvac/robot.py", line 70, in get_robot_state
return self._message({'reqId': "1", 'cmd': "getRobotState"})
File "/home/homeassistant/.homeassistant/deps/pybotvac/robot.py", line 44, in _message
response.raise_for_status()
File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/requests/models.py", line 909, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://nucleo.neatocloud.com/vendors/neato/robots/OPS23516-***********/messages
@turbokongen turbokongen mentioned this issue Mar 21, 2017
Merged
turbokongen added a commit that referenced this issue Apr 3, 2017
@turbokongen
Fix for #6691 Neato Connection error handling (#6731)
a107a59 
* Responsiveness

* Delay was not needed as commands does not return until done.

* Offline error catch

* Remove unneeded code
@fabaff fabaff mentioned this issue Apr 6, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #6691 Neato Connection error handling turbokongen/home-assistant
1 participant
@emilp333
0