8000 ACs show up as fans in HomeKit · Issue #81445 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ACs show up as fans in HomeKit #81445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agneevX opened this issue Nov 3, 2022 · 20 comments · Fixed by #81473 or #81613
Closed

ACs show up as fans in HomeKit #81445

agneevX opened this issue Nov 3, 2022 · 20 comments · Fixed by #81473 or #81613
Assignees
@bdraco
Labels
integration: homekit

Comments

@agneevX
Copy link
agneevX commented Nov 3, 2022 •
edited
Loading

The problem

Since 2022.11.0, ACs have been showing up as fans in the Home app.

What version of Home Assistant Core has the issue?

core-2022.11.0

What was the last working version of Home Assistant Core?

2022.10.5

What type of installation are you running?

Home Assistant Container

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response
@home-assistant
Copy link
home-assistant bot commented Nov 3, 2022

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)

homekit documentation
homekit source
(message by IssueLinks)

@bdraco
Copy link
Member
bdraco commented Nov 3, 2022

Assuming you paired it before 2022.11.0, you’ll need to unpair and repair the bridge as you have an accessory on the same bridge that previously did not have a stable iid

For more details see the breaking change for HomeKit in the release notes

@agneevX
Copy link
Author
agneevX commented Nov 3, 2022

I removed the bridge from iOS Home and Home Assistant, created a new bridge in HA and re-added it to iOS Home and the ACs still show up as fans.

FWIW, on downgrading to 2022.10.5, they immediately showed up as ACs.

In the screenshot above, note that the fan appears over the climate controls, it used to be the other way around before.

@bdraco
Copy link
Member
bdraco commented Nov 3, 2022

Thats concerning considering since we haven't changed the thermostat code since september

https://github.com/home-assistant/core/commits/2022.11.0/homeassistant/components/homekit/type_thermostats.py

I'm not sure whats going on.

@bdraco
Copy link
Member
bdraco commented Nov 3, 2022

When did you create the original bridge?

@agneevX
Copy link
Author
agneevX commented Nov 3, 2022

At least a year back.

@bdraco
Copy link
Member
bdraco commented Nov 3, 2022

I'm thinking whats happening is the service linkage needs to be the other way, but since the iids were unstable before when fan support was added the linkage was never seen.

The HomeKit docs don't specify which direction the linkage should be though so its a bit a guess work. I can't test a change though since I'm traveling.

@bdraco
Copy link
Member
bdraco commented Nov 3, 2022 •
edited
Loading

If you are in a position to test, apply the below patch, restart, unpair, and repair

commit 82a17b851a1b31457b395754bf6c79ac58ce5135
Author: J. Nick Koston <nick@koston.org>
Date:   Thu Nov 3 10:55:15 2022 +0100

    switch linkage

diff --git a/homeassistant/components/homekit/type_thermostats.py b/homeassistant/components/homekit/type_thermostats.py
index a924548816..a8c7a53718 100644
--- a/homeassistant/components/homekit/type_thermostats.py
+++ b/homeassistant/components/homekit/type_thermostats.py
@@ -306,7 +306,7 @@ class Thermostat(HomeAccessory):
             if attributes.get(ATTR_HVAC_ACTION) is not None:
                 self.fan_chars.append(CHAR_CURRENT_FAN_STATE)
             serv_fan = self.add_preload_service(SERV_FANV2, self.fan_chars)
-            serv_thermostat.add_linked_service(serv_fan)
+            serv_fan.add_linked_service(serv_thermostat)
             self.char_active = serv_fan.configure_char(
                 CHAR_ACTIVE, value=1, setter_callback=self._set_fan_active
             )

@agneevX
Copy link
Author
agneevX commented Nov 3, 2022

That patch fixes the issue, can confirm, thanks.

@agneevX
Copy link
Author
agneevX commented Nov 3, 2022

However, the fan continues to show above the climate controls.

@bdraco
Copy link
Member
bdraco commented Nov 3, 2022

However, the fan continues to show above the climate controls.

You might need to restart the device and all the home hubs as well (or wait a few hours)

@bdraco bdraco mentioned this issue Nov 3, 2022
Merged
19 tasks
@lixaster
Copy link
lixaster commented Nov 5, 2022

I have the same problem on version 2022.11.0. When I update to 2022.11.1, I unpair, repair the ACs, some of them still show up as fans.

@bdraco bdraco reopened this Nov 5, 2022
@bdraco
Copy link
Member
bdraco commented Nov 5, 2022

@lixplus0 Please post diagnostics

@lixaster
Copy link
lixaster commented Nov 5, 2022

@lixplus0 Please post diagnostics

Thanks but where could I find the diagnostics? It seems homeassistant did not report any error.

@bdraco
Copy link
Member
bdraco commented Nov 5, 2022

You can find it on the integrations screen by clicking the tree dots next to the integration

@bdraco bdraco mentioned this issue Nov 5, 2022
Merged
19 tasks
@lixaster
Copy link
lixaster commented Nov 5, 2022 •
edited
Loading

You can find it on the integrations screen by clicking the tree dots next to the integration

In this condition, five ACs were under this bridge. one was identified as AC, the other four were identified as Fans.
Everytime I create a new birdge, the situation changes, e.g., 2 as ACs and 3 as Fans.
My Homepodmini is the center. My iPhone version is ios 16.1.

config_entry-homekit-4a097c1e80cf4bf74f206e883b60abeb.json.txt

@bdraco
Copy link
Member
bdraco commented Nov 5, 2022

Thanks. I see the problem. Working on a fix

@sibartlett
Copy link

I had the same issue, but I found you can change the position of the fan controls in the home app - by tapping near the climate controls, and then closing and re-opening the accessory. In the end, I resorted to unlinking the tiles.

@bdraco
Copy link
Member
bdraco commented Nov 9, 2022

Please try 2022.11.2

@lixaster
Copy link
lixaster commented Nov 9, 2022

Please try 2022.11.2

Thanks, 2022.11.2 fixed the issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bdraco bdraco

Labels
integration: homekit
Projects
None yet
Milestone
No milestone
5 participants
@frenck @sibartlett @bdraco @agneevX @lixaster
0