8000 Fix homekit bridge iid allocations by bdraco · Pull Request #81613 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix homekit bridge iid allocations #81613 < 8000 /h1>
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged
merged 19 commits into from
Nov 8, 2022
Merged

Fix homekit bridge iid allocations #81613

merged 19 commits into from
Nov 8, 2022

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Nov 5, 2022 •
edited
Loading

Proposed change

The original change to use stable iid allocations failed to account for the fact that special case that the 3E service (Accessory Information Service) must always have iid 1 for the child accessories on a bridge as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Fix homekit iid allocations
a0496c0 
The original change to use stable iid allocations failed to account
for the fact that the 3E service must always have iid 1 for the
child accessories on a bridge as well.
@bdraco bdraco added this to the 2022.11.2 milestone Nov 5, 2022
@bdraco bdraco mentioned this pull request Nov 5, 2022
Merged
@bdraco bdraco changed the title Fix homekit iid allocations Fix homekit bridge iid allocations Nov 5, 2022
@bdraco bdraco marked this pull request as ready for review November 5, 2022 17:14
@bdraco bdraco marked this pull request as draft November 5, 2022 23:02
@bdraco
Copy link
Member Author
bdraco commented Nov 5, 2022 •
edited
Loading

Still an issue when the trigger has an underscore in it

bdraco added 2 commits November 5, 2022 18:11
@bdraco
fix: add more cover
0c5a32c
@bdraco
copy the correct fixture in
< 8000 div class="pr-1 flex-shrink-0" style="width: 16px;">
cb3e9db
@bdraco bdraco marked this pull request as ready for review November 5, 2022 23:17
@balloob balloob merged commit 53c1c2e into home-assistant:dev Nov 8, 2022
frenck pushed a commit that referenced this pull request Nov 8, 2022
@bdraco @frenck
Fix homekit bridge iid allocations (#81613)
ac15f2c 
fixes undefined
@frenck frenck mentioned this pull request Nov 8, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: homekit Quality Scale: No score
Projects
None yet
Milestone
2022.11.2
Development

Successfully merging this pull request may close these issues.

ACs show up as fans in HomeKit
3 participants
@bdraco @balloob @frenck
0