8000 Remove relative time sensor from cert_expiry by chemelli74 · Pull Request #42338 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove relative time sensor from cert_expiry #42338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2020
Merged

Remove relative time sensor from cert_expiry #42338

merged 3 commits into from
Nov 13, 2020

Conversation

chemelli74
Copy link
Contributor
@chemelli74 chemelli74 commented Oct 25, 2020 •
edited
Loading

Breaking change

In order to optimize stability and performance of HomeAssistant, sensors should use only absolute time values (store the date of the event) and not relative time values (seconds from event) so the db value doesn't change each seconds.
"cert_expiry" integration has both of them, so to adhere to HomeAssistant development rules, the offending sensor is now removed.
If your config was based on it, please switch to the other one.

Removed relative time sensor from cert_expiry

Proposed change

Removed relative time sensor from cert_expiry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck
Copy link
Member
frenck commented Oct 25, 2020

Could you adjust the text in the breaking change field to be end-user friendly? For example, explain why this was removed, and preferably, if available, an alternative.

@chemelli74
Copy link
Contributor Author

Could you adjust the text in the breaking change field to be end-user friendly? For example, explain why this was removed, and preferably, if available, an alternative.

Done, let me know if it's good enough now.

Simone

@MartinHjelmare
Copy link
Member

The description has confused the relative and absolute time terms. It's the days unit sensor that uses relative time and the timestamp sensor that uses absolute time.

@chemelli74
Copy link
Contributor Author

The description has confused the relative and absolute time terms. It's the days unit sensor that uses relative time and the timestamp sensor that uses absolute time.

Yeah you are right, I changed the way of expressing and swapped the terms.

Simone

@MartinHjelmare
Copy link
Member

This PR is removing the relative time sensor. We should update that too in the description.

@chemelli74 chemelli74 changed the title Removed absolute time sensor from cert_expiry Removed relative time sensor from cert_expiry Oct 25, 2020
@springstan springstan changed the title Removed relative time sensor from cert_expiry Remove relative time sensor from cert_expiry Oct 26, 2020
@MartinHjelmare
Copy link
Member

I've updated the description regarding relative vs absolute sensor removal.

@MartinHjelmare
Copy link
Member

Please update the first paragraph in the docs page for this integration:
https://www.home-assistant.io/integrations/cert_expiry/

Link the docs PR in this PR description. Then we can merge.

@chemelli74
Copy link
Contributor Author

Please update the first paragraph in the docs page for this integration:
https://www.home-assistant.io/integrations/cert_expiry/

Link the docs PR in this PR description. Then we can merge.

Done.

Simone

@MartinHjelmare MartinHjelmare merged commit 7bcd921 into home-assistant:dev Nov 13, 2020
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 13, 2020
Merge branch 'dev' of https://github.com/home-assistant/core into dev
7af7552 
* 'dev' of https://github.com/home-assistant/core: (32 commits)
  Disable parsing scientific/complex number notation in template type (home-assistant#43170)
  Remove relative time sensor from cert_expiry (home-assistant#42338)
  Further improve MFI tests (home-assistant#43167)
  Update translations
  Guard against empty ssdp locations (home-assistant#43156)
  Fix playing of Spotify URIs on Sonos (home-assistant#43154)
  Add missing 'hassio' translation string (home-assistant#43127)
  Streamline SimpliSafe errors (home-assistant#43117)
  Update xknx to 0.15.3 (home-assistant#42026)
  Fix beat calculation (home-assistant#43142)
  Mock time_date sensor tests (home-assistant#43141)
  [ci skip] Translation update
  Fix bug preventing Notion entities from updating their bridge (home-assistant#43122)
  Bump hass-nabucasa to 0.37.2 (home-assistant#43146)
  Shelly: minor improvements (home-assistant#43138)
  Add support for learning RF commands with Broadlink remotes (home-assistant#39671)
  Fix incorrect Notion battery state calculation (home-assistant#43108)
  Bump hatasmota to 0.0.30 (home-assistant#43140)
  Add VSCode debug launch conf (home-assistant#43130)
  Revert "shelly_naming" rebase errors (home-assistant#43134)
  ...
@chemelli74 chemelli74 deleted the chemelli74-cert_expiry branch November 13, 2020 12:49
@frenck frenck mentioned this pull request Nov 13, 2020
Merged
8 tasks
rccoleman pushed a commit to rccoleman/core that referenced this pull request Dec 4, 2020
@chemelli74 @rccoleman
Remove relative time sensor from cert_expiry (home-assistant#42338)
b870310
@asychev asychev mentioned this pull request Jan 18, 2021
Closed
@chemelli74 chemelli74 mentioned this pull request Jun 7, 2021
Closed
21 tasks
@chemelli74 chemelli74 mentioned this pull request Nov 13, 2021
Closed
22 tasks
@bdraco bdraco mentioned this pull request Dec 5, 2021
Merged
@rikroe rikroe mentioned this pull request Dec 21, 2021
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@jjlawren jjlawren

Labels
breaking-cha 5B61 nge cla-signed code-quality Hacktoberfest hacktoberfest-accepted integration: cert_expiry small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cert_expiry integration create a second sensor with relative time
5 participants
@chemelli74 @frenck @MartinHjelmare @jjlawren @homeassistant
0