Fix ONVIF subscription renew #42651
Merged
Fix ONVIF subscription renew #42651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fails after setup
MartinHjelmare
approved these changes
Oct 31, 2020
|
Go ahead and merge when the testing is done. |
|
@hunterjm gave me the updated code and I put it on my system which was experiencing the issue. Previously, the memory usage would grow at a steep rate until system failure (within 6 hours or so). With the updated code, I've been running stable for the past 16 hours with no apparent memory leak. |
Merged
|
@hunterjm This commit seems to have broken the Motion Events sensor in my setup. I was fine on 117.1, and with the update to HA 117.2 the sensor has become Unavailable. |
|
@ricarva Please do not use comments on handled/closed/merged PRs to report a bug. Instead, create an issue in the issue tracker here on GitHub. Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The ONVIF subscription renewal fails after the changes in 0.117 that attempted to setup events for cameras that didn't advertise supporting them. This adds a renewal at the beginning before starting the event service to ensure we no longer get stuck in a loop.
I have someone running this change as a custom component currently to verify the fix.
Long term fix would be to add support for relative time renewals. The reason this is failing is because some cameras don't support both absolute and relative renewals like they are supposed to. That should be a separate PR.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: