8000 Bump pwmled to v1.6.6 by soldag · Pull Request #42607 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump pwmled to v1.6.6 #42607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2020
Merged

Bump pwmled to v1.6.6 #42607

merged 1 commit into from
Nov 1, 2020

Conversation

soldag
Copy link
Contributor
@soldag soldag commented Oct 29, 2020 •
edited
Loading

Proposed change

Mainly improves performance of transitions and fixes configuring the frequency when using a gpio driver.

soldag/python-pwmled@v1.5.3...v1.6.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

springstan
springstan approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member
@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@soldag
Copy link
Contributor Author
soldag commented Oct 31, 2020

Ready to merge from my side. CI just failed because GitHub was not available at that time and I can't rerun it.

@springstan
Copy link
Member

@soldag does this version bump solve #42650?

@soldag soldag changed the title Bump pwmled to v1.6.5 Bump pwmled to v1.6.6 Nov 1, 2020
@soldag
Copy link
Contributor Author
soldag commented Nov 1, 2020

@springstan Fixed it in v1.6.6 of the lib and changed this MR accordingly. Thanks for referencing the issue. I wasn't aware of it.

@springstan
Copy link
Member

Of course, fyi you can add yourself as codeowner of this integration so you are automatically tagged when an issue or PR comes up regarding this integration.

@springstan
Copy link
Member

Tagging this for the next patch release since it fixes an issue that came up in 0.117.

@springstan springstan added this to the 0.117.2 milestone Nov 1, 2020
@springstan springstan merged commit be058d1 into home-assistant:dev Nov 1, 2020
balloob pushed a commit that referenced this pull request Nov 1, 2020
@soldag @balloob
Bump pwmled to v1.6.6 (#42607)
faf73e3
@balloob balloob mentioned this pull request Nov 1, 2020
Merged
@springstan springstan mentioned this pull request Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed dependency dependency-bump Hacktoberfest hacktoberfest-accepted integration: rpi_gpio_pwm small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.117.2
Development

Successfully merging this pull request may close these issues.

rpi_gpio_pwm error after upgrade to 0.117.1
5 participants
@soldag @springstan @balloob @MartinHjelmare @homeassistant
0