8000 Fix Fibaro HC2 climate device missing temperature by airthusiast · Pull Request #42627 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Fibaro HC2 climate device miss 8000 ing temperature #42627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fix Fibaro HC2 climate device missing temperature #42627

merged 1 commit into from
Oct 30, 2020

Conversation

airthusiast
Copy link
Contributor
@airthusiast airthusiast commented Oct 30, 2020 •
edited by springstan
Loading

Proposed change

When using Fibaro HC2, temperature (current and target) retrieval was crashing.
Causing other properties to be ignored and not shown anymore (battera_level + fibaro_id).

This small PR fixes it.

Related to issue:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@springstan springstan changed the title Fix Fibaro HC2 climate device temperature (get) Fix Fibaro HC2 climate device missing temperature Oct 30, 2020
springstan
springstan approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member
@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 will tag this for 0.117.2 since it fixes two issues.

@springstan springstan added this to the 0.117.2 milestone Oct 30, 2020
@springstan springstan merged commit c894476 into home-assistant:dev Oct 30, 2020
@airthusiast airthusiast deleted the fix-bug-42623 branch October 30, 2020 23:51
balloob pushed a commit that referenced this pull request Nov 1, 2020
@airthusiast @balloob
Fix Fibaro HC2 climate device missing temperature (#42627)
6d54ed1
@balloob balloob mentioned this pull request Nov 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed Hacktoberfest
Projects
None yet
Milestone
0.117.2
Development

Successfully merging this pull request may close these issues.

Fix #42300 breaks thermostat support for Fibaro HC2 Climate no longer working
4 participants
@airthusiast @springstan @balloob @homeassistant
0