8000 Fix geo_rss_events import statement by exxamalte · Pull Request #42629 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix geo_rss_events import statement #42629
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fix geo_rss_events import statement #42629

merged 2 commits into from
Oct 30, 2020

Conversation

exxamalte
Copy link
Contributor
@exxamalte exxamalte commented Oct 30, 2020 •
edited
Loading

Breaking change

Proposed change

This fixes a broken import statement in the geo_rss_events platform. At the same time the integration library will be updated to ensure this fix is also pulling in the correct version.

The reason this import statement broke in the first place was because I excluded test source code from a library that the integration library is dependent on, and which this import statement was falsely using as a side-effect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: geo_rss_events
    name: NSW Fire Service
    url: http://www.rfs.nsw.gov.au/feeds/majorIncidents.xml
    radius: 15
    unit_of_measurement: Incidents
    categories:
      - 'Emergency Warning'
      - 'Watch and Act'
      - 'Advice'

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare merged commit 8c239f2 into home-assistant:dev Oct 30, 2020
@MartinHjelmare
Copy link
Member

Should we tag this for a patch release?

@exxamalte
Copy link
Contributor Author

Yes, please.

@MartinHjelmare MartinHjelmare added this to the 0.117.2 milestone Oct 30, 2020
@exxamalte exxamalte deleted the fix-geo-rss-events branch October 30, 2020 11:46
balloob pushed a commit that referenced this pull request Nov 1, 2020
@exxamalte @balloob
Fix geo_rss_events import statement (#42629)
2430c5e 
* bump integration library version

* fix import statement
@balloob balloob mentioned this pull request Nov 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed Hacktoberfest integration: geo_rss_events small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.117.2
Development

Successfully merging this pull request may close these issues.

geo_rss_events causing error during config check
4 participants
@exxamalte @MartinHjelmare @balloob @homeassistant
0