8000 Fix API change with Notion batteries by bachya · Pull Request #43073 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix API change with Notion batteries #43073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix API change with Notion batteries #43073

merged 1 commit into from
Nov 11, 2020

Conversation

bachya
Copy link
Contributor
@bachya bachya commented Nov 11, 2020

Proposed change

This PR fixes a bug in the Notion integration that arose from an underlying change in the API that returns battery info.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Nov 11, 2020
@bachya bachya merged commit 9b58b24 into home-assistant:dev Nov 11, 2020
@bachya bachya deleted the fix-43029 branch November 11, 2020 01:00
@bachya bachya mentioned this pull request Nov 11, 2020
Merged
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ctalkington ctalkington ctalkington approved these changes

Assignees

@bachya bachya

Labels
bugfix by-code-owner cla-signed integration: notion small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notion battery sensors showing “unavailable” all the time
3 participants
@bachya @ctalkington @homeassistant
0