Synology SSL fix & Error handling #4325
Conversation
| EVENT_HOMEASSISTANT_STOP, _async_close_synlogy_websession) | ||
|
|
||
| websession = hass.data.get(DATA_WEBSESSION) | ||
| else |
There was a problem hiding this comment.
- 10: E999 SyntaxError: invalid syntax
|
|
||
| websession = hass.data.get(DATA_WEBSESSION) | ||
| else | ||
| websession = hass.websession |
There was a problem hiding this comment.
- 9: E113 unexpected indentation
c1d3c86 to
dd0b823
Compare
|
Can any one with synology test that? @jgriff2 |
|
Traceback (most recent call last): |
|
You can't pass cookies as an argument to aiohttp.ClientSession.get() |
|
Line 64 should also be an |
|
Yeah, I need to change to generic request function and stay only the connector to data |
|
@jgriff2 please a new test |
|
Traceback (most recent call last): |
|
Please also change line 62 from |
|
@jgriff2 try agen 👍 |
|
Traceback (most recent call last): |
|
@jgriff2 fixed |
|
Camera loads now and you get the preview on the main page. If you click and try to get streaming video you get this error: |
|
that is also fixed @jgriff2 |
|
Looks good. |
* Synology SSL fix & Error handling * change handling for cookies/ssl * fix use not deprecated functions * fix lint * change verify * fix connector close to coro * fix force close * not needed since websession close connector too * fix params * fix lint
Description:
Enable the old stuff to disable the ssl verifycation back.
@balloob I think this platform has to many device specifying code inside. Wrapped in a API it would more readable...
Related issue (if applicable): #4296 #4257
CC @jgriff2