Track deCONZ lib changes to light based devices 8000 #43366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary sensor should use state rather than is_tripped Add some more tests to lights and sensors
balloob
reviewed
Nov 23, 2020
balloob
approved these changes
Nov 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Main reason for change:
deCONZ are changing the API to certain devices so it is time to move the knowledge about them into pydeCONZ.
Main changes to library:
Add specific classes for ConfigurationTool, Cover, Fan, Lock and Siren based in light resources.
Add new classes AirQuality and Time to sensors.
Cleaned up sensors a bit, minimising the difference between binary and non binary sensors.
Increased testing of library up to near 100% coverage.
Kane610/deconz@v73...v74
Breaking change(?):
Don't create entity for Configuration tool which is only a representation of the deCONZ hardware. Previously exposed as a confusing and unusable light.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m scri 8000 pt.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: