8000 Bump envoy_reader version to 0.17.0 by gtdiehl · Pull Request #43498 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump envoy_reader version to 0.17.0 #43498 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2020
Merged

Bump envoy_reader version to 0.17.0 #43498

merged 1 commit into from
Nov 22, 2020

Conversation

gtdiehl
Copy link
Contributor
@gtdiehl gtdiehl commented Nov 21, 2020 •
edited
Loading

Proposed change

Fix an a bug where envoy_reader will return an incorrect zero value for current energy Production. envoy_reader also includes an enhancement to reduce the amount of retrievals that are done by the API.

envoy_reader api change log

I have checked that this PR is related to #42857 only because both PRs contain HTTP optimizations and should probably be released together to see the full effect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: enphase_envoy
    ip_address: !secret enphase_ip_addr
    username: !secret enphase_user
    password: !secret enphase_pass
    monitored_conditions:
      - production
      - daily_production
      - seven_days_production
      - lifetime_production
      - inverters

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

davet2001
davet2001 approved these changes Nov 21, 2020
View reviewed changes
Copy link
Contributor
@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Danielhiversen Danielhiversen merged commit a633341 into home-assistant:dev Nov 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2020
@gtdiehl gtdiehl deleted the bump_envoy_0170 branch November 23, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Danielhiversen Danielhiversen Danielhiversen approved these changes

@davet2001 davet2001 davet2001 approved these changes

Assignees
No one assigned
Labels
cla-signed dependency dependency-bump integration: enphase_envoy small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gtdiehl @Danielhiversen @davet2001 @homeassistant
0