8000 Add webhook to default config by frenck · Pull Request #43521 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add webhook to default config #43521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2020
Merged

Add webhook to default config #43521

merged 2 commits into from
Nov 23, 2020

Conversation

frenck
Copy link
Member
@frenck frenck commented Nov 22, 2020

Proposed change

Recently the triggers have moved into their respective integration space. However, this also means that triggers are only loaded when the integration is active.

In the case of webhooks, this means the webhook trigger can only be used, if the component is activated or is pulled in as a dependency of another component (e.g., mobile_app).

This PR adds the webhook component to the default configuration, as webhooks have a use-case on their own (as an automation trigger).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

squishykid
squishykid approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor
@squishykid squishykid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgarwood cgarwood merged commit 612e747 8CCB into dev Nov 23, 2020
@cgarwood cgarwood deleted the frenck-2020-0942 branch November 23, 2020 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squishykid squishykid squishykid approved these changes

@cgarwood cgarwood cgarwood approved these changes

Assignees
No one assigned
Labels
bugfix cla-signed core dependency-bump integration: default_config small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automation webhooks only enable if mobile_app integration is loaded.
4 participants
@frenck @squishykid @cgarwood @homeassistant
0