10000 Fix deadlock if an integration from stage_1 fails by pvizeli · Pull Request #43657 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix deadlock if an integration from stage_1 fails #43657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2020
Merged

Fix deadlock if an integration from stage_1 fails #43657

merged 1 commit into from
Nov 26, 2020

Conversation

pvizeli
Copy link
Member
@pvizeli pvizeli commented Nov 26, 2020 •
edited
Loading

Breaking change

Proposed change

Fix a deadlock of https://github.com/home-assistant/core/blob/dev/homeassistant/setup.py#L109-L111

Happening if a stage_1 integration fails to setup. Now it gets mark as setup again which is wrong. The codebase supports this change because he checks anyway if somethings is marked as setup in progress or not.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pvizeli pvizeli added this to the 0.118.4 milestone Nov 26, 2020
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Nov 26, 2020
@balloob balloob merged commit d4f9c19 into dev Nov 26, 2020
@balloob balloob deleted the fix-deadlock branch November 26, 2020 10:38
balloob pushed a commit that referenced this pull request Nov 26, 2020
@pvizeli @balloob
Fix deadlock if an integration from stage_1 fails (#43657)
ecaa9d9
@balloob balloob mentioned this pull request Nov 26, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.118.4
Development

Successfully merging this pull request may close these issues.
4 participants
@pvizeli @bdraco @balloob @homeassistant
0