Increase timeout for snapshot upload #43851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Dec 2, 2020
| @@ -89,9 +90,10 @@ async def _command_proxy( | |||
| request._client_max_size = ( # pylint: disable=protected-access | |||
| MAX_UPLOAD_SIZE | |||
| ) | |||
| client_timeout = 300 | |||
There was a problem hiding this comment.
We could, but then it would never timeout 🤷
worst case you upload 1GB, with 5min it will still timeout if your connection is slower than 29Mb/s.
This should only be done in a local network, I think that is a reasonable max value?
But if you feel we should have None (disabled) I can update it.
There was a problem hiding this comment.
So is this timeout only for the uploading, or also the processing?
There was a problem hiding this comment.
Only the upload, and only the first part of the upload (between the client (browser) and HA).
When that part is done, HA sends this to SU which will process it (save).
There was a problem hiding this comment.
Writing to SD is not a part of this
balloob
approved these changes
Dec 2, 2020
pvizeli
approved these changes
Dec 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Increases the timeout between the client and HA for snapshot uploads from 10 to 300 seconds.
Fixes the 502 error you get on slower devices that uses > 10s for the upload.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: