8000 Fix importing blueprint from community by bramkragten · Pull Request #44104 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix importing 8000 blueprint from community #44104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2020
Merged

Fix importing blueprint from community #44104

merged 3 commits into from
Dec 10, 2020

Conversation

bramkragten
Copy link
Member
@bramkragten bramkragten commented Dec 10, 2020 •
edited
Loading

Proposed change

Fix importing blueprints from the forums which contain HTML entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: blueprint small-pr PRs with less than 30 lines. labels Dec 10, 2020
@bramkragten bramkragten added this to the 1.0.0 milestone Dec 10, 2020
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (blueprint) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit 0da312b into dev Dec 10, 2020
@balloob balloob deleted the fix-html-import branch December 10, 2020 15:46
frenck pushed a commit that referenced this pull request Dec 10, 2020
@bramkragten @frenck
Fix importing blueprint from community (#44104)
83b7439
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed integration: blueprint small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bramkragten @balloob @frenck @homeassistant
0