8000 Support overriding token in notifify.event service by papajojo · Pull Request #47133 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support overriding token in notifify.event se 8000 rvice #47133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2021
Merged

Support overriding token in notifify.event service #47133

merged 2 commits into from
Mar 25, 2021

Conversation

papajojo
Copy link
Contributor
@papajojo papajojo commented Feb 27, 2021 •
edited by emontnemery
Loading

Proposed change

Support overriding token in notifify.event service

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
notify:
  - name: events
    platform: notify_events
    token: YOUR_TOKEN

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @matrozov, mind taking a look at this pull request as its been labeled with an integration (notify_events) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck mentioned this pull request Mar 3, 2021
Merged
8 tasks
@emontnemery emontnemery changed the title Add opportunity to define token for each message Optionally provide a unique token to notifify_events send_message service Mar 23, 2021
@emontnemery emontnemery changed the title Optionally provide a unique token to notifify_events send_message service Support overriding token in notifify_events.send_message service Mar 23, 2021
@emontnemery emontnemery changed the title Support overriding token in notifify_events.send_message service Support overriding token in notifify.event service Mar 23, 2021
emontnemery
emontnemery reviewed Mar 23, 2021
View reviewed changes
@emontnemery
Copy link
Contributor

On a general note, the notify_events integration should have some tests added (not blocking this PR though).

@papajojo @emontnemery
Update homeassistant/components/notify_events/notify.py
1df29fc 
Co-authored-by: Erik Montnemery <erik@montnemery.com>
emontnemery
emontnemery approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor
@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @papajojo 👍

@emontnemery emontnemery merged commit 056f7d4 into home-assistant:dev Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: notify_events new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papajojo @emontnemery @homeassistant
0