8000 Fix update of surveillance_station data in Synology DSM by mib1185 · Pull Request #47966 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix update of surveillance_station data in Synology DSM #47966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix update of surveillance_station data in Synology DSM #47966

merged 1 commit into from
Mar 31, 2021

Conversation

mib1185
Copy link
Contributor
@mib1185 mib1185 commented Mar 15, 2021

Proposed change

This PR with remove API updates for surveillance_station from async_coordinator_update_data_central, because thees updates are done by separate async_coordinator_update_data_cameras.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix integration: synology_dsm Synology DSM small-pr PRs with less than 30 lines. labels Mar 15, 2021
@probot-home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Quentame
Quentame reviewed Mar 15, 2021
View reviewed changes
homeassistant/components/synology_dsm/__init__.py Outdated
@@ -502,7 +505,6 @@ def _async_setup_api_requests(self):
"Disable surveillance_station api from being updated for '%s'",
self._entry.unique_id,
)
self.dsm.reset(self.surveillance_station)
self.surveillance_station = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove all the condition ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right ... this condition is not needed anymore 👍

@mib1185 mib1185 force-pushed the synology-dsm_fix-surveillancestation-updates branch from 63c29aa to 0828867 Compare March 16, 2021 20:13
@mib1185 mib1185 requested a review from Quentame March 16, 2021 20:14
bdraco
bdraco approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco
Copy link
Member
bdraco commented Mar 31, 2021

@Quentame Any more comments?

frenck
frenck approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@frenck frenck merged commit 949cd47 into home-assistant:dev Mar 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
@mib1185 mib1185 deleted the synology-dsm_fix-surveillancestation-updates branch May 11, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@bdraco bdraco bdraco approved these changes

@Quentame Quentame Awaiting requested review from Quentame Quentame is a code owner

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed integration: synology_dsm Synology DSM small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected error fetching cameras data
5 participants
@mib1185 @bdraco @frenck @Quentame @homeassistant
0