10000 KNX passive group addresses by farmio · Pull Request #48009 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

KNX passive group addresses #48009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2021
Merged

KNX passive group addresses #48009

merged 5 commits into from
Mar 30, 2021

Conversation

farmio
Copy link
Contributor
@farmio farmio commented Mar 16, 2021 •
edited
Loading

Proposed change

Add possibility to configure passive / listening group addresses for every knx function (except expose and notify).
This allows to have multiple group addresses to update the state of an entity function. Group addresses can now be configured as lists where the first item is the active sending or state-reading address and the rest is registered as passive addresses.
This schema behaves like in ETS configuration where the first is the "sending" address and others are just for updating the communication object.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
knx:
  switch:
    - name: "Switch without passive addresses"
      address: "1/1/1"
      state_address: "7/7/7"
    - name: "Switch with passive addresses"
      address: 
        - "1/1/1" # this is the address that will be sent to
        - "2/2/2" # this and following are passive addresses
        - "3/3/3"
      state_address: 
        - "7/7/7" # this is the address GroupValueRead requests are sent to
        - "7/7/8" # this and following are passive addresses
        - "7/7/9"

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

ping @Tolriq

@probot-home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@farmio farmio mentioned this pull request Mar 19, 2021
Merged
8 tasks
marvin-w
marvin-w approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor
@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

frenck
frenck reviewed Mar 29, 2021
View reviewed changes
@farmio farmio requested a review from frenck March 30, 2021 05:40
frenck
frenck approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @farmio 👍

@frenck frenck merged commit 338be8c into home-assistant:dev Mar 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
@farmio farmio deleted the knx-passive-addresses branch May 31, 2021 05:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@marvin-w marvin-w marvin-w approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: knx new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farmio @frenck @marvin-w @homeassistant
0