8000 Cloud: Expose if google is registered in status + check on login by bramkragten · Pull Request #48260 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cloud: Expose if google is registered in status + check on login #48260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 29, 2021
Merged

Cloud: Expose if google is registered in status + check on login #48260

merged 7 commits into from
Mar 29, 2021

Conversation

bramkragten
Copy link
Member

Proposed change

This adds information if Google Assistant is setup, so the frontend can handle that correctly.
We also check if Google Assistant was setup when you login to your Cloud account, and activate it.

Related: #48233

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with an integration (cloud) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

balloob
balloob reviewed Mar 23, 2021
View reviewed changes
@bramkragten bramkragten force-pushed the expose_if_reged_google_cloud branch from bf08439 to bade7ce Compare March 24, 2021 15:27
@bramkragten bramkragten mentioned this pull request Mar 24, 2021
Merged
9 tasks
balloob
balloob reviewed Mar 24, 2021
View reviewed changes
balloob
balloob reviewed Mar 24, 2021
View reviewed changes
@bramkragten bramkragten force-pushed the expose_if_reged_google_cloud branch from acf6878 to b1b5d7b Compare March 29, 2021 16:06
@bramkragten bramkragten merged commit 03b7b13 into dev Mar 29, 2021
@bramkragten bramkragten deleted the expose_if_reged_google_cloud branch March 29, 2021 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: cloud new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bramkragten @balloob @homeassistant
0