8000 Provide the improved service UX with deCONZ services by Kane610 · Pull Request #48382 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Provide the improved service UX with deCONZ services #48382 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 31, 2021
Merged

Provide the improved service UX with deCONZ services #48382

merged 12 commits into from
Mar 31, 2021

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Mar 26, 2021

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 changed the title use the new improved services in deCONZ Use the new improved services in deCONZ Mar 26, 2021
@Kane610 Kane610 changed the title Use the new improved services in deCONZ Provide the improved service UX with deCONZ services Mar 30, 2021
frenck
frenck requested changes Mar 31, 2021
View reviewed changes
Kane610 and others added 8 commits March 31, 2021 18:53
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
8000
085475e 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
19ce17c 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
4049fe2 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
041ecc0 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
5823b64 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
09e8637 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610 @frenck
Update homeassistant/components/deconz/services.yaml
fe3dfdf 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@Kane610
Update homeassistant/components/deconz/services.yaml
3314b83 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
frenck approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do the object right now, I'm doubting side effects with how the value is wrapped.

@bramkragten
Copy link
Member

Data should be a json object? Or a string?

If the first, it should be object.

Otherwise maybe use multiline?

@frenck
Copy link
Member
frenck commented Mar 31, 2021

Went through the code, it ends up as the json parameter of the request, which expects a Python dictionary. Thus object is the right one in this case + YAML can be used as well.

frenck
frenck reviewed Mar 31, 2021
View reviewed changes
@frenck frenck merged commit bc5d828 into home-assistant:dev Mar 31, 2021
@Kane610
Copy link
Member Author
Kane610 commented Mar 31, 2021

Thanks @frenck and @bramkragten 🎉

@Kane610 Kane610 deleted the deconz-support_improved_service_definitions branch March 31, 2021 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality integration: deconz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kane610 @bramkragten @frenck @homeassistant
0