8000 Add emonitor integration by bdraco · Pull Request #48310 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add emonitor integration #48310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 5, 2021
Merged

Add emonitor integration #48310

merged 18 commits into from
Apr 5, 2021

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Mar 25, 2021 •
edited
Loading

Proposed change

The SiteSage Emonitor allows local power monitoring on a per circuit basis via an Emonitor device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

bdraco
bdraco commented Mar 25, 2021
View reviewed changes
@bdraco bdraco mentioned this pull request Mar 25, 2021
Merged
8 tasks
bdraco
bdraco commented Mar 25, 2021
View reviewed changes
bdraco
bdraco commented Mar 25, 2021
View reviewed changes
bdraco
bdraco commented Mar 25, 2021
View reviewed changes
bdraco
bdraco commented Mar 27, 2021
View reviewed changes
balloob
balloob reviewed Apr 5, 2021
View reviewed changes
balloob
balloob reviewed Apr 5, 2021
View reviewed changes
balloob
balloob reviewed Apr 5, 2021
View reviewed changes
bdraco and others added 3 commits April 4, 2021 21:27
@bdraco @balloob
Update homeassistant/components/emonitor/__init__.py
f063373 
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco @balloob
Update homeassistant/components/emonitor/__init__.py
fc9317e 
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco
remove test for async_setup
151905c
@bdraco
Copy link
Member Author
bdraco commented Apr 5, 2021

Thanks. Retested 👍

@bdraco bdraco merged commit e925fd2 into home-assistant:dev Apr 5, 2021
MartinHjelmare
MartinHjelmare reviewed Apr 5, 2021
View reviewed changes
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed has-tests integration: emonitor new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdraco @balloob @MartinHjelmare @homeassistant
0