8000 Create homekit locks according to spec by bdraco · Pull Request #48453 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Create homekit locks according to spec #48453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Create homekit locks according to spec #48453

merged 1 commit into from
Mar 31, 2021

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Mar 29, 2021 •
edited
Loading

Proposed change

Create homekit locks according to spec

The spec states: "Any accessories, regardless of transport, that enable physical access to the home, such as door locks, must not be bridged."

We were bridging them by default which explains why the notifications were unreliable and there was problem with discovery by iOS

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Create homekit locks according to spec
0f227e8 
Any accessories, regardless of transport, that enable physical access to the home, such as door locks, must not be bridged.
@bdraco bdraco mentioned this pull request Mar 29, 2021
Merged
8 tasks
@balloob balloob merged commit 9790f3f into home-assistant:dev Mar 31, 2021
@bdraco
Copy link
Member Author
bdraco commented Mar 31, 2021

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: homekit small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @balloob @homeassistant
0