8000 Add asyncio locks to screenlogic api access points by dieselrabbit · Pull Request #48457 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add asyncio locks to scre 8000 enlogic api access points #48457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2021
Merged

Add asyncio locks to screenlogic api access points #48457

merged 3 commits into from
Mar 29, 2021

Conversation

dieselrabbit
Copy link
Contributor

Proposed change

Add asyncio locks to api access points to protect api's shared socket against collisions/destruction.
FIxes a possible [Errno 9] Bad file descriptor when multiple switches are listed in a single call to switch.toggle/turn_on/turn_off

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@dieselrabbit dieselrabbit mentioned this pull request Mar 29, 2021
Closed
21 tasks
@MartinHjelmare MartinHjelmare changed the title Add asyncio locks to api access points. Add asyncio locks to screenlogic api access points Mar 29, 2021
MartinHjelmare
MartinHjelmare approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bdraco
bdraco approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

CI failure is unrelated. I restarted it, but it should be good to merge reguardless

@dieselrabbit @bdraco
Bump screenlogicpy to 0.2.2.
56cd865 
API fixes shared socket collision when commands are called by multiple threads.
@dieselrabbit @bdraco
Revert "Bump screenlogicpy to 0.2.2."
0d21fe7 
This reverts commit 870f4bc.
@dieselrabbit @bdraco
Add asyncio locks to api access points.
e26e516 
Protects api shared socket collisions/destruction.
@bdraco bdraco force-pushed the screenlogic-lock branch from 4a42d2e to e26e516 Compare March 29, 2021 23:03
@bdraco
Copy link
Member
bdraco commented Mar 29, 2021 •
edited
Loading

I rebased to upstream/dev so we can get a clean CI run.

I'll merge it as soon as it passes

@bdraco bdraco merged commit 42a060a into home-assistant:dev Mar 29, 2021
@dieselrabbit
Copy link
Contributor Author

I rebased to upstream/dev so we can get a clean CI run.

I'll merge it as soon as it passes

Thank you!

@dieselrabbit dieselrabbit deleted the screenlogic-lock branch March 30, 2021 04:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed integration: screenlogic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dieselrabbit @bdraco @MartinHjelmare @homeassistant
0