8000 Add support for Selectors in Script service fields by frenck · Pull Request #48469 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for Selectors in Script service fields 8000 #48469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

Add support for Selectors in Script service fields #48469

merged 1 commit into from
Mar 29, 2021

Conversation

frenck
Copy link
Member
@frenck frenck commented Mar 29, 2021 •
edited
Loading

Proposed change

This PR enables support for using Selectors in Script fields, bringing the UI to scripts.
Everything was in place already, just the schema was missing. This PR adds just that.

image

image

Docs PR: home-assistant/home-assistant.io#17171

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
script:
  sunlight:
    alias: sunlight
    description: Description
    mode: parallel
    max: 100
    fields:
      brightness:
        name: Brightness
        description: Brightness in %, overrides circadian brightness
        example: 75
        default: 50
        required: true
        advanced: true
        selector:
          number:
            min: 0
            max: 100
            step: 1
            unit_of_measurement: "%"
            mode: slider

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck mentioned this pull request Mar 29, 2021
Merged
8 tasks
@frenck frenck marked this pull request as ready for review March 29, 2021 15:14
@frenck frenck merged commit 81ae0ee into dev Mar 29, 2021
@frenck frenck deleted the frenck-2021-1000 branch March 29, 2021 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: script new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frenck @pvizeli @homeassistant
0