Fix Nest doing I/O inside event loop #4855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @technicalpickles, @fabaff and @pvizeli to be potential reviewers. |
21 tasks
|
I had seen that warning before, but didn't know what caused it 👍 In general, should formatting happen during update? Or is it just because there's a replace happening? |
|
This was the offending line |
| @@ -128,13 +128,20 @@ def __init__(self, structure, device, variable): | |||
|
|
|||
| # device specific | |||
| self._location = self.device.where | |||
| self._name = self.device.name_long | |||
| self._name = "{} {}".format(self.device.name_long, | |||
| self.variable.replace("_", " ")) | |||
There was a problem hiding this comment.
This line introduced this error when you have Cameras:
16-12-16 11:16:52 ERROR (MainThread) [homeassistant.components.binary_sensor] Error while setting up platform nest
Traceback (most recent call last):
File "/Users/technicalpickles/src/picklehome/vendor/home-assistant/homeassistant/helpers/entity_component.py", line 150, in _async_setup_platform
entity_platform.add_entities, discovery_info
File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/futures.py", line 361, in __iter__
yield self # This tells Task to wait for completion.
File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
future.result()
File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/futures.py", line 274, in result
raise self._exception
File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/concurrent/futures/thread.py", line 55, in run
result = self.fn(*self.args, **self.kwargs)
File "/Users/technicalpickles/src/picklehome/vendor/home-assistant/homeassistant/components/binary_sensor/nest.py", line 98, in setup_platform
activity_zone)]
File "/Users/technicalpickles/src/picklehome/vendor/home-assistant/homeassistant/components/binary_sensor/nest.py", line 121, in __init__
super(NestActivityZoneSensor, self).__init__(structure, device, None)
File "/Users/technicalpickles/src/picklehome/vendor/home-assistant/homeassistant/components/sensor/nest.py", line 136, in __init__
self.variable.replace("_", " "))
AttributeError: 'NoneType' object has no attribute 'replace'
It looks like it's my bad use of inheritence, where an NestActivityZoneSensor in the binary sensor passes in variable of None, since it's doing it's own thing.
I'll followup with a PR to fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes Nest doing I/O inside the event loop as reported in #4210 (comment)
CC @technicalpickles