8000 Include script script_execution in script and automation traces by emontnemery · Pull Request #48576 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include script script_execution in script and automation traces #48576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2021
Merged

Include script script_execution in script and automation traces #48576

merged 4 commits into from
Apr 1, 2021

Conversation

emontnemery
Copy link
Contributor
@emontnemery emontnemery commented Apr 1, 2021 •
edited
Loading

Proposed change

Include script script_execution in script and automation traces

script_execution is set according to:

  • The script was not executed because the automation's condition failed
    • script_execution = failed_condition
  • The script was not executed because the run mode is single
    • script_execution = failed_single
  • The script was not executed because max parallel runs would be exceeded
    • script_execution = failed_max_runs
  • All script steps finished:
    • script_execution = "finished"
  • Script execution stopped by the script itself because a condition fails, wait_for_trigger timeouts etc:
    • script_execution = "aborted"
    • Details about failing condition, timeout etc. is in the last element of the trace
  • Script execution stops because of an unexpected exception:
    • script_execution = "error"
    • The exception is in the trace itself or in the last element of the trace
  • Script execution stopped by async_stop called on the script run because home assistant is shutting down, script mode is SCRIPT_MODE_RESTART etc:
    • script_execution = "cancelled"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery emontnemery changed the title Include script stop_reason in script and automation traces Include script script_execution in script and automation traces Apr 1, 2021
@balloob balloob merged commit 9f481e1 into home-assistant:dev Apr 1, 2021
@balloob balloob mentioned this pull request Apr 1, 2021
Merged
9 tasks
@balloob balloob added this to the 2021.4.0 milestone Apr 1, 2021
balloob pushed a commit that referenced this pull request Apr 1, 2021
@emontnemery @balloob
Include script script_execution in script and automation traces (#48576)
e760c23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core has-tests integration: trace new-feature
Projects
None yet
Milestone
2021.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @balloob @homeassistant
0