-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Add missing neato error status #48508
8000New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing neato error status #48508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need some clarity on where this error came from since its not in the API docs
@@ -119,6 +119,7 @@ | |||
"nav_backdrop_frontbump": "Clear my path", | |||
"nav_backdrop_leftbump": "Clear my path", | |||
"nav_backdrop_wheelextended": "Clear my path", | |||
"nav_floorplan_zone_path_blocked": "Clear my path", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see this in the official neato docs which is what we are replicating. How did you come to find this error?
https://developers.neatorobotics.com/api/robot-remote-protocol/request-response-formats
Everything in this list needs to be documented on this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My D7 got stuck. I explored state with pybotvac and stubbled upon it.
>>> pprint(robot.state)
{'action': 11,
'alert': None,
'availableCommands': {'goToBase': False,
'pause': False,
'resume': False,
'start': False,
'stop': False},
'availableServices': {'IECTest': 'advanced-1',
'findMe': 'basic-1',
'generalInfo': 'basic-1',
'houseCleaning': 'basic-4',
'logCopy': 'basic-1',
'manualCleaning': 'basic-1',
'maps': 'basic-2',
'preferences': 'basic-2',
'schedule': 'basic-2',
'softwareUpdate': 'basic-1',
'spotCleaning': 'basic-3',
'wifi': 'basic-1'},
'cleaning': {'boundary': {'id': 'e841e843-892d-4499-996b-77fc0c3bf5a9',
'name': 'Entrée'},
'category': 4,
'mapId': '2021-03-08T07:34:50Z',
'mode': 2,
'modifier': 1,
'navigationMode': 3,
'spotHeight': 0,
'spotWidth': 0},
'data': {},
'details': {'charge': 98,
'dockHasBeenSeen': True,
'isCharging': False,
'isDocked': False,
'isScheduleEnabled': True},
'error': 'nav_floorplan_zone_path_blocked',
'meta': {'firmware': '4.6.0-72', 'modelName': 'BotVacD7Connected'},
'reqId': '1',
'result': 'ok',
'state': 4,
'version': 1}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldnt be the first time the neato docs were out of date to the actual API :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you know what it looks like you have a later firmware update than I do and there are no updates available yet for my D7's. Maybe they are getting ready to introduce this change. My firmware is on 4.5.3-189. Hopefully that is the only change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup you got some unreleased/undocumented firmware 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol! I bought it few weeks ago from Boulanger.fr
They have access to a secret dev path 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Breaking change
Proposed change
Add a missing error message.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: